* [PATCH] 9p: Remove unneeded idr.h #include in the net/9p directory
@ 2022-11-27 14:46 Christophe JAILLET
2022-11-27 15:14 ` Christian Schoenebeck
2022-12-02 14:59 ` Dominique Martinet
0 siblings, 2 replies; 3+ messages in thread
From: Christophe JAILLET @ 2022-11-27 14:46 UTC (permalink / raw)
To: Eric Van Hensbergen, Latchesar Ionkov, Dominique Martinet,
Christian Schoenebeck, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, v9fs-developer,
netdev
The 9p net files don't use IDR or IDA functionalities. So there is no point
in including <linux/idr.h>.
Remove it.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
net/9p/trans_fd.c | 1 -
net/9p/trans_rdma.c | 1 -
net/9p/trans_virtio.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c
index eeea0a6a75b6..06ec9f7d3318 100644
--- a/net/9p/trans_fd.c
+++ b/net/9p/trans_fd.c
@@ -20,7 +20,6 @@
#include <linux/un.h>
#include <linux/uaccess.h>
#include <linux/inet.h>
-#include <linux/idr.h>
#include <linux/file.h>
#include <linux/parser.h>
#include <linux/slab.h>
diff --git a/net/9p/trans_rdma.c b/net/9p/trans_rdma.c
index 6ff706760676..33a9ac6f2d55 100644
--- a/net/9p/trans_rdma.c
+++ b/net/9p/trans_rdma.c
@@ -21,7 +21,6 @@
#include <linux/un.h>
#include <linux/uaccess.h>
#include <linux/inet.h>
-#include <linux/idr.h>
#include <linux/file.h>
#include <linux/parser.h>
#include <linux/semaphore.h>
diff --git a/net/9p/trans_virtio.c b/net/9p/trans_virtio.c
index e757f0601304..19bccfa0d593 100644
--- a/net/9p/trans_virtio.c
+++ b/net/9p/trans_virtio.c
@@ -22,7 +22,6 @@
#include <linux/un.h>
#include <linux/uaccess.h>
#include <linux/inet.h>
-#include <linux/idr.h>
#include <linux/file.h>
#include <linux/highmem.h>
#include <linux/slab.h>
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] 9p: Remove unneeded idr.h #include in the net/9p directory
2022-11-27 14:46 [PATCH] 9p: Remove unneeded idr.h #include in the net/9p directory Christophe JAILLET
@ 2022-11-27 15:14 ` Christian Schoenebeck
2022-12-02 14:59 ` Dominique Martinet
1 sibling, 0 replies; 3+ messages in thread
From: Christian Schoenebeck @ 2022-11-27 15:14 UTC (permalink / raw)
To: Eric Van Hensbergen, Latchesar Ionkov, Dominique Martinet,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Christophe JAILLET
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, v9fs-developer,
netdev
On Sunday, November 27, 2022 3:46:45 PM CET Christophe JAILLET wrote:
> The 9p net files don't use IDR or IDA functionalities. So there is no point
> in including <linux/idr.h>.
> Remove it.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
Reviewed-by: Christian Schoenebeck <linux_oss@crudebyte.com>
> net/9p/trans_fd.c | 1 -
> net/9p/trans_rdma.c | 1 -
> net/9p/trans_virtio.c | 1 -
> 3 files changed, 3 deletions(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] 9p: Remove unneeded idr.h #include in the net/9p directory
2022-11-27 14:46 [PATCH] 9p: Remove unneeded idr.h #include in the net/9p directory Christophe JAILLET
2022-11-27 15:14 ` Christian Schoenebeck
@ 2022-12-02 14:59 ` Dominique Martinet
1 sibling, 0 replies; 3+ messages in thread
From: Dominique Martinet @ 2022-12-02 14:59 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Eric Van Hensbergen, Latchesar Ionkov, Christian Schoenebeck,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
linux-kernel, kernel-janitors, v9fs-developer, netdev
Christophe JAILLET wrote on Sun, Nov 27, 2022 at 03:46:45PM +0100:
> The 9p net files don't use IDR or IDA functionalities. So there is no point
> in including <linux/idr.h>.
> Remove it.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Thanks, picked this one up as well
--
Dominique
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-02 15:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-27 14:46 [PATCH] 9p: Remove unneeded idr.h #include in the net/9p directory Christophe JAILLET
2022-11-27 15:14 ` Christian Schoenebeck
2022-12-02 14:59 ` Dominique Martinet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).