netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] ibmvnic: remove unused rc variable
@ 2023-08-04  9:21 Yu Liao
  2023-08-04 14:11 ` Nick Child
  2023-08-06 12:30 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: Yu Liao @ 2023-08-04  9:21 UTC (permalink / raw)
  To: netdev; +Cc: liaoyu15, liwei391, nnac123, davem

gcc with W=1 reports
drivers/net/ethernet/ibm/ibmvnic.c:194:13: warning: variable 'rc' set but not used [-Wunused-but-set-variable]
                                            ^
This variable is not used so remove it.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202308040609.zQsSXWXI-lkp@intel.com/
Signed-off-by: Yu Liao <liaoyu15@huawei.com>
---
 drivers/net/ethernet/ibm/ibmvnic.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ethernet/ibm/ibmvnic.c b/drivers/net/ethernet/ibm/ibmvnic.c
index 763d613adbcc..01535b03eab6 100644
--- a/drivers/net/ethernet/ibm/ibmvnic.c
+++ b/drivers/net/ethernet/ibm/ibmvnic.c
@@ -191,9 +191,8 @@ static void ibmvnic_clean_affinity(struct ibmvnic_adapter *adapter)
 	struct ibmvnic_sub_crq_queue **rxqs;
 	struct ibmvnic_sub_crq_queue **txqs;
 	int num_rxqs, num_txqs;
-	int rc, i;
+	int i;
 
-	rc = 0;
 	rxqs = adapter->rx_scrq;
 	txqs = adapter->tx_scrq;
 	num_txqs = adapter->num_active_tx_scrqs;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] ibmvnic: remove unused rc variable
  2023-08-04  9:21 [PATCH -next] ibmvnic: remove unused rc variable Yu Liao
@ 2023-08-04 14:11 ` Nick Child
  2023-08-06 12:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Nick Child @ 2023-08-04 14:11 UTC (permalink / raw)
  To: Yu Liao, netdev; +Cc: liwei391, davem

LGTM thanks!

On 8/4/23 04:21, Yu Liao wrote:
> gcc with W=1 reports
> drivers/net/ethernet/ibm/ibmvnic.c:194:13: warning: variable 'rc' set but not used [-Wunused-but-set-variable]
>                                              ^
> This variable is not used so remove it.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202308040609.zQsSXWXI-lkp@intel.com/
> Signed-off-by: Yu Liao <liaoyu15@huawei.com>

Reviewed-by: Nick Child <nnac123@linux.ibm.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] ibmvnic: remove unused rc variable
  2023-08-04  9:21 [PATCH -next] ibmvnic: remove unused rc variable Yu Liao
  2023-08-04 14:11 ` Nick Child
@ 2023-08-06 12:30 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-08-06 12:30 UTC (permalink / raw)
  To: Yu Liao; +Cc: netdev, liwei391, nnac123, davem

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Fri, 4 Aug 2023 17:21:43 +0800 you wrote:
> gcc with W=1 reports
> drivers/net/ethernet/ibm/ibmvnic.c:194:13: warning: variable 'rc' set but not used [-Wunused-but-set-variable]
>                                             ^
> This variable is not used so remove it.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202308040609.zQsSXWXI-lkp@intel.com/
> Signed-off-by: Yu Liao <liaoyu15@huawei.com>
> 
> [...]

Here is the summary with links:
  - [-next] ibmvnic: remove unused rc variable
    https://git.kernel.org/netdev/net-next/c/813f3662c240

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-08-06 12:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-04  9:21 [PATCH -next] ibmvnic: remove unused rc variable Yu Liao
2023-08-04 14:11 ` Nick Child
2023-08-06 12:30 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).