From: patchwork-bot+netdevbpf@kernel.org
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com
Subject: Re: [PATCH net-next] net: omit ndo_hwtstamp_get() call when possible in dev_set_hwtstamp_phylib()
Date: Sun, 06 Aug 2023 12:30:21 +0000 [thread overview]
Message-ID: <169132502159.16904.16690341040047268621.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230804134939.3109763-1-vladimir.oltean@nxp.com>
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:
On Fri, 4 Aug 2023 16:49:39 +0300 you wrote:
> Setting dev->priv_flags & IFF_SEE_ALL_HWTSTAMP_REQUESTS is only legal
> for drivers which were converted to ndo_hwtstamp_get() and
> ndo_hwtstamp_set(), and it is only there that we call ndo_hwtstamp_set()
> for a request that otherwise goes to phylib (for stuff like packet traps,
> which need to be undone if phylib failed, hence the old_cfg logic).
>
> The problem is that we end up calling ndo_hwtstamp_get() when we don't
> need to (even if the SIOCSHWTSTAMP wasn't intended for phylib, or if it
> was, but the driver didn't set IFF_SEE_ALL_HWTSTAMP_REQUESTS). For those
> unnecessary conditions, we share a code path with virtual drivers (vlan,
> macvlan, bonding) where ndo_hwtstamp_get() is implemented as
> generic_hwtstamp_get_lower(), and may be resolved through
> generic_hwtstamp_ioctl_lower() if the lower device is unconverted.
>
> [...]
Here is the summary with links:
- [net-next] net: omit ndo_hwtstamp_get() call when possible in dev_set_hwtstamp_phylib()
https://git.kernel.org/netdev/net-next/c/c35e927cbe09
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-08-06 12:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 13:49 [PATCH net-next] net: omit ndo_hwtstamp_get() call when possible in dev_set_hwtstamp_phylib() Vladimir Oltean
2023-08-06 12:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169132502159.16904.16690341040047268621.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).