From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4A2124526 for ; Wed, 9 Aug 2023 20:20:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 8D020C433C7; Wed, 9 Aug 2023 20:20:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1691612422; bh=IgWIGYwbaRVg8Dh8flKqrLiWRhpgkgMSBj7YBNAiP2w=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=lpuV8K7/7jDQsintPKm4aHtHxPO3qhVwX83XopO+Pm1x59Qa1Bh14rI0Qs4IQ3LY/ tIdAqMBNo0gyoX+R25glS6agq1XbZfdJhcDMd3N1ZM4iM101++JDx++YCOaPVPfgIE azY2jbV4nQMoUqQCRp5GEl1hepqgexyQ0/XDjl+7S+OWHAJct55ucdCuEPD1/mCHcB B9P5VZXqz9FQgMS9gAUgWZmgAtGIWLZaIaeVVpLJUvio1qZHYG2C1YTy5kbjQjyaCY kTKCnEvzNjUUNSSr54vBHsgMpvwdTQwUJXHqkmWuN+1h1AiVnik6/r1XKAtilnPo53 7x/Vn/Bi29ilg== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 7489BE33090; Wed, 9 Aug 2023 20:20:22 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net-next] net: dsa: mark parsed interface mode for legacy switch drivers From: patchwork-bot+netdevbpf@kernel.org Message-Id: <169161242247.16318.3088407520751400257.git-patchwork-notify@kernel.org> Date: Wed, 09 Aug 2023 20:20:22 +0000 References: In-Reply-To: To: Russell King (Oracle) Cc: andrew@lunn.ch, hkallweit1@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Tue, 08 Aug 2023 12:12:16 +0100 you wrote: > If we successfully parsed an interface mode with a legacy switch > driver, populate that mode into phylink's supported interfaces rather > than defaulting to the internal and gmii interfaces. > > This hasn't caused an issue so far, because when the interface doesn't > match a supported one, phylink_validate() doesn't clear the supported > mask, but instead returns -EINVAL. phylink_parse_fixedlink() doesn't > check this return value, and merely relies on the supported ethtool > link modes mask being cleared. Therefore, the fixed link settings end > up being allowed despite validation failing. > > [...] Here is the summary with links: - [net-next] net: dsa: mark parsed interface mode for legacy switch drivers https://git.kernel.org/netdev/net-next/c/145622771d22 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html