From: patchwork-bot+netdevbpf@kernel.org
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, camelia.groza@nxp.com,
ioana.ciornei@nxp.com, andrew@lunn.ch, hkallweit1@gmail.com,
rmk+kernel@armlinux.org.uk
Subject: Re: [PATCH net-next] net: pcs: lynx: fix lynx_pcs_link_up_sgmii() not doing anything in fixed-link mode
Date: Sun, 13 Aug 2023 11:40:21 +0000 [thread overview]
Message-ID: <169192682172.1919.731891096559433284.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230811115352.1447081-1-vladimir.oltean@nxp.com>
Hello:
This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:
On Fri, 11 Aug 2023 14:53:52 +0300 you wrote:
> lynx_pcs_link_up_sgmii() is supposed to update the PCS speed and duplex
> for the non-inband operating modes, and prior to the blamed commit, it
> did just that, but a mistake sneaked into the conversion and reversed
> the condition.
>
> It is easy for this to go undetected on platforms that also initialize
> the PCS in the bootloader, because Linux doesn't reset it (although
> maybe it should). The nature of the bug is that phylink will not touch
> the IF_MODE_HALF_DUPLEX | IF_MODE_SPEED_MSK fields when it should, and
> it will apparently keep working if the previous values set by the
> bootloader were correct.
>
> [...]
Here is the summary with links:
- [net-next] net: pcs: lynx: fix lynx_pcs_link_up_sgmii() not doing anything in fixed-link mode
https://git.kernel.org/netdev/net-next/c/2f4503f94c5d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-08-13 11:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 11:53 [PATCH net-next] net: pcs: lynx: fix lynx_pcs_link_up_sgmii() not doing anything in fixed-link mode Vladimir Oltean
2023-08-11 11:55 ` Russell King (Oracle)
2023-08-13 11:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169192682172.1919.731891096559433284.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew@lunn.ch \
--cc=camelia.groza@nxp.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=ioana.ciornei@nxp.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).