[PATCH net-next] selftests: vrf_route_leaking: remove ipv6_ping_frag from default testing

[PATCH net-next] selftests: vrf_route_leaking: remove ipv6_ping_frag from default testing

[Hangbin Liu]

As the initial commit 1a01727676a8 ("selftests: Add VRF route leaking
tests") said, the IPv6 MTU test fails as source address selection
picking ::1. Every time we run the selftest this one report failed.
There seems not much meaning  to keep reporting a failure for 3 years
that no one plan to fix/update. Let't just skip this one first. We can
add it back when the issue fixed.

Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
 tools/testing/selftests/net/vrf_route_leaking.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/net/vrf_route_leaking.sh b/tools/testing/selftests/net/vrf_route_leaking.sh
index 23cf924754a5..dedc52562b4f 100755
--- a/tools/testing/selftests/net/vrf_route_leaking.sh
+++ b/tools/testing/selftests/net/vrf_route_leaking.sh
@@ -565,7 +565,7 @@ EOF
 command -v ping6 > /dev/null 2>&1 && ping6=$(command -v ping6) || ping6=$(command -v ping)
 
 TESTS_IPV4="ipv4_ping_ttl ipv4_traceroute ipv4_ping_frag ipv4_ping_ttl_asym ipv4_traceroute_asym"
-TESTS_IPV6="ipv6_ping_ttl ipv6_traceroute ipv6_ping_frag ipv6_ping_ttl_asym ipv6_traceroute_asym"
+TESTS_IPV6="ipv6_ping_ttl ipv6_traceroute ipv6_ping_ttl_asym ipv6_traceroute_asym"
 
 ret=0
 nsuccess=0
-- 
2.38.1

Re: [PATCH net-next] selftests: vrf_route_leaking: remove ipv6_ping_frag from default testing

[David Ahern]

On 8/18/23 2:06 AM, Hangbin Liu wrote:
> As the initial commit 1a01727676a8 ("selftests: Add VRF route leaking
> tests") said, the IPv6 MTU test fails as source address selection
> picking ::1. Every time we run the selftest this one report failed.
> There seems not much meaning  to keep reporting a failure for 3 years
> that no one plan to fix/update. Let't just skip this one first. We can
> add it back when the issue fixed.
> 
> Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
> ---
>  tools/testing/selftests/net/vrf_route_leaking.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/vrf_route_leaking.sh b/tools/testing/selftests/net/vrf_route_leaking.sh
> index 23cf924754a5..dedc52562b4f 100755
> --- a/tools/testing/selftests/net/vrf_route_leaking.sh
> +++ b/tools/testing/selftests/net/vrf_route_leaking.sh
> @@ -565,7 +565,7 @@ EOF
>  command -v ping6 > /dev/null 2>&1 && ping6=$(command -v ping6) || ping6=$(command -v ping)
>  
>  TESTS_IPV4="ipv4_ping_ttl ipv4_traceroute ipv4_ping_frag ipv4_ping_ttl_asym ipv4_traceroute_asym"
> -TESTS_IPV6="ipv6_ping_ttl ipv6_traceroute ipv6_ping_frag ipv6_ping_ttl_asym ipv6_traceroute_asym"
> +TESTS_IPV6="ipv6_ping_ttl ipv6_traceroute ipv6_ping_ttl_asym ipv6_traceroute_asym"
>  
>  ret=0
>  nsuccess=0

Needs to be fixed, but clearly not a high priority. I am ok with
disabling the failed test:

Reviewed-by: David Ahern <dsahern@kernel.org>

Re: [PATCH net-next] selftests: vrf_route_leaking: remove ipv6_ping_frag from default testing

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Fri, 18 Aug 2023 16:06:13 +0800 you wrote:
> As the initial commit 1a01727676a8 ("selftests: Add VRF route leaking
> tests") said, the IPv6 MTU test fails as source address selection
> picking ::1. Every time we run the selftest this one report failed.
> There seems not much meaning  to keep reporting a failure for 3 years
> that no one plan to fix/update. Let't just skip this one first. We can
> add it back when the issue fixed.
> 
> [...]

Here is the summary with links:
  - [net-next] selftests: vrf_route_leaking: remove ipv6_ping_frag from default testing
    https://git.kernel.org/netdev/net-next/c/c4cf2bc0d2c9

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html