* [PATCH net-next] bonding: update port speed when getting bond speed
@ 2023-08-21 10:10 Hangbin Liu
2023-08-21 22:57 ` Jay Vosburgh
2023-08-22 13:30 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Hangbin Liu @ 2023-08-21 10:10 UTC (permalink / raw)
To: netdev
Cc: Jay Vosburgh, David S . Miller, Jakub Kicinski, Paolo Abeni,
Eric Dumazet, Liang Li, Jiri Pirko, Nikolay Aleksandrov,
Hangbin Liu, Andrew Schorr
Andrew reported a bonding issue that if we put an active-back bond on top
of a 802.3ad bond interface. When the 802.3ad bond's speed/duplex changed
dynamically. The upper bonding interface's speed/duplex can't be changed at
the same time, which will show incorrect speed.
Fix it by updating the port speed when calling ethtool.
Reported-by: Andrew Schorr <ajschorr@alumni.princeton.edu>
Closes: https://lore.kernel.org/netdev/ZEt3hvyREPVdbesO@Laptop-X1/
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
---
drivers/net/bonding/bond_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 447b06ea4fc9..07c2e46d27a8 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -5706,6 +5706,7 @@ static int bond_ethtool_get_link_ksettings(struct net_device *bond_dev,
*/
bond_for_each_slave(bond, slave, iter) {
if (bond_slave_can_tx(slave)) {
+ bond_update_speed_duplex(slave);
if (slave->speed != SPEED_UNKNOWN) {
if (BOND_MODE(bond) == BOND_MODE_BROADCAST)
speed = bond_mode_bcast_speed(slave,
--
2.41.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] bonding: update port speed when getting bond speed
2023-08-21 10:10 [PATCH net-next] bonding: update port speed when getting bond speed Hangbin Liu
@ 2023-08-21 22:57 ` Jay Vosburgh
2023-08-22 13:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Jay Vosburgh @ 2023-08-21 22:57 UTC (permalink / raw)
To: Hangbin Liu
Cc: netdev, David S . Miller, Jakub Kicinski, Paolo Abeni,
Eric Dumazet, Liang Li, Jiri Pirko, Nikolay Aleksandrov,
Andrew Schorr
Hangbin Liu <liuhangbin@gmail.com> wrote:
>Andrew reported a bonding issue that if we put an active-back bond on top
>of a 802.3ad bond interface. When the 802.3ad bond's speed/duplex changed
>dynamically. The upper bonding interface's speed/duplex can't be changed at
>the same time, which will show incorrect speed.
>
>Fix it by updating the port speed when calling ethtool.
>
>Reported-by: Andrew Schorr <ajschorr@alumni.princeton.edu>
>Closes: https://lore.kernel.org/netdev/ZEt3hvyREPVdbesO@Laptop-X1/
>Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com>
>---
> drivers/net/bonding/bond_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
>index 447b06ea4fc9..07c2e46d27a8 100644
>--- a/drivers/net/bonding/bond_main.c
>+++ b/drivers/net/bonding/bond_main.c
>@@ -5706,6 +5706,7 @@ static int bond_ethtool_get_link_ksettings(struct net_device *bond_dev,
> */
> bond_for_each_slave(bond, slave, iter) {
> if (bond_slave_can_tx(slave)) {
>+ bond_update_speed_duplex(slave);
> if (slave->speed != SPEED_UNKNOWN) {
> if (BOND_MODE(bond) == BOND_MODE_BROADCAST)
> speed = bond_mode_bcast_speed(slave,
>--
>2.41.0
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] bonding: update port speed when getting bond speed
2023-08-21 10:10 [PATCH net-next] bonding: update port speed when getting bond speed Hangbin Liu
2023-08-21 22:57 ` Jay Vosburgh
@ 2023-08-22 13:30 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-08-22 13:30 UTC (permalink / raw)
To: Hangbin Liu
Cc: netdev, j.vosburgh, davem, kuba, pabeni, edumazet, liali, jiri,
razor, ajschorr
Hello:
This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Mon, 21 Aug 2023 18:10:08 +0800 you wrote:
> Andrew reported a bonding issue that if we put an active-back bond on top
> of a 802.3ad bond interface. When the 802.3ad bond's speed/duplex changed
> dynamically. The upper bonding interface's speed/duplex can't be changed at
> the same time, which will show incorrect speed.
>
> Fix it by updating the port speed when calling ethtool.
>
> [...]
Here is the summary with links:
- [net-next] bonding: update port speed when getting bond speed
https://git.kernel.org/netdev/net-next/c/691b2bf14946
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-08-22 13:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-21 10:10 [PATCH net-next] bonding: update port speed when getting bond speed Hangbin Liu
2023-08-21 22:57 ` Jay Vosburgh
2023-08-22 13:30 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).