From: patchwork-bot+netdevbpf@kernel.org
To: Ido Schimmel <idosch@nvidia.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, edumazet@google.com, razor@blackwall.org,
jiri@nvidia.com, mlxsw@nvidia.com
Subject: Re: [PATCH net] rtnetlink: Reject negative ifindexes in RTM_NEWLINK
Date: Thu, 24 Aug 2023 08:00:23 +0000 [thread overview]
Message-ID: <169286402339.1543.14446432556518633186.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230823064348.2252280-1-idosch@nvidia.com>
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Wed, 23 Aug 2023 09:43:48 +0300 you wrote:
> Negative ifindexes are illegal, but the kernel does not validate the
> ifindex in the ancillary header of RTM_NEWLINK messages, resulting in
> the kernel generating a warning [1] when such an ifindex is specified.
>
> Fix by rejecting negative ifindexes.
>
> [1]
> WARNING: CPU: 0 PID: 5031 at net/core/dev.c:9593 dev_index_reserve+0x1a2/0x1c0 net/core/dev.c:9593
> [...]
> Call Trace:
> <TASK>
> register_netdevice+0x69a/0x1490 net/core/dev.c:10081
> br_dev_newlink+0x27/0x110 net/bridge/br_netlink.c:1552
> rtnl_newlink_create net/core/rtnetlink.c:3471 [inline]
> __rtnl_newlink+0x115e/0x18c0 net/core/rtnetlink.c:3688
> rtnl_newlink+0x67/0xa0 net/core/rtnetlink.c:3701
> rtnetlink_rcv_msg+0x439/0xd30 net/core/rtnetlink.c:6427
> netlink_rcv_skb+0x16b/0x440 net/netlink/af_netlink.c:2545
> netlink_unicast_kernel net/netlink/af_netlink.c:1342 [inline]
> netlink_unicast+0x536/0x810 net/netlink/af_netlink.c:1368
> netlink_sendmsg+0x93c/0xe40 net/netlink/af_netlink.c:1910
> sock_sendmsg_nosec net/socket.c:728 [inline]
> sock_sendmsg+0xd9/0x180 net/socket.c:751
> ____sys_sendmsg+0x6ac/0x940 net/socket.c:2538
> ___sys_sendmsg+0x135/0x1d0 net/socket.c:2592
> __sys_sendmsg+0x117/0x1e0 net/socket.c:2621
> do_syscall_x64 arch/x86/entry/common.c:50 [inline]
> do_syscall_64+0x38/0xb0 arch/x86/entry/common.c:80
> entry_SYSCALL_64_after_hwframe+0x63/0xcd
>
> [...]
Here is the summary with links:
- [net] rtnetlink: Reject negative ifindexes in RTM_NEWLINK
https://git.kernel.org/netdev/net/c/30188bd7838c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-08-24 8:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-23 6:43 [PATCH net] rtnetlink: Reject negative ifindexes in RTM_NEWLINK Ido Schimmel
2023-08-24 2:06 ` Jakub Kicinski
2023-08-24 8:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169286402339.1543.14446432556518633186.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=razor@blackwall.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).