* [PATCH] net: arcnet: Do not call kfree_skb() under local_irq_disable()
@ 2023-08-24 6:43 Jinjie Ruan
2023-08-25 9:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Jinjie Ruan @ 2023-08-24 6:43 UTC (permalink / raw)
To: netdev, Michael Grzeschik, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: ruanjinjie
It is not allowed to call kfree_skb() from hardware interrupt
context or with hardware interrupts being disabled.
So replace kfree_skb() with dev_kfree_skb_irq() under
local_irq_disable(). Compile tested only.
Fixes: 05fcd31cc472 ("arcnet: add err_skb package for package status feedback")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
drivers/net/arcnet/arcnet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/arcnet/arcnet.c b/drivers/net/arcnet/arcnet.c
index 99265667538c..d9e052c49ba1 100644
--- a/drivers/net/arcnet/arcnet.c
+++ b/drivers/net/arcnet/arcnet.c
@@ -464,7 +464,7 @@ static void arcnet_reply_tasklet(struct tasklet_struct *t)
ret = sock_queue_err_skb(sk, ackskb);
if (ret)
- kfree_skb(ackskb);
+ dev_kfree_skb_irq(ackskb);
local_irq_enable();
};
--
2.34.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net: arcnet: Do not call kfree_skb() under local_irq_disable()
2023-08-24 6:43 [PATCH] net: arcnet: Do not call kfree_skb() under local_irq_disable() Jinjie Ruan
@ 2023-08-25 9:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-08-25 9:20 UTC (permalink / raw)
To: Jinjie Ruan; +Cc: netdev, m.grzeschik, davem, edumazet, kuba, pabeni
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Thu, 24 Aug 2023 14:43:36 +0800 you wrote:
> It is not allowed to call kfree_skb() from hardware interrupt
> context or with hardware interrupts being disabled.
> So replace kfree_skb() with dev_kfree_skb_irq() under
> local_irq_disable(). Compile tested only.
>
> Fixes: 05fcd31cc472 ("arcnet: add err_skb package for package status feedback")
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
>
> [...]
Here is the summary with links:
- net: arcnet: Do not call kfree_skb() under local_irq_disable()
https://git.kernel.org/netdev/net/c/786c96e92fb9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-25 9:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-24 6:43 [PATCH] net: arcnet: Do not call kfree_skb() under local_irq_disable() Jinjie Ruan
2023-08-25 9:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).