From: patchwork-bot+netdevbpf@kernel.org
To: John Fastabend <john.fastabend@gmail.com>
Cc: olsajiri@gmail.com, xukuohai@huawei.com, eddyz87@gmail.com,
edumazet@google.com, cong.wang@bytedance.com,
bpf@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH bpf] bpf: sockmap, fix skb refcnt race after locking changes
Date: Mon, 04 Sep 2023 08:13:49 +0000 [thread overview]
Message-ID: <169381522938.3122.223485705283897635.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230901202137.214666-1-john.fastabend@gmail.com>
Hello:
This patch was applied to bpf/bpf.git (master)
by Daniel Borkmann <daniel@iogearbox.net>:
On Fri, 1 Sep 2023 13:21:37 -0700 you wrote:
> There is a race where skb's from the sk_psock_backlog can be referenced
> after userspace side has already skb_consumed() the sk_buff and its
> refcnt dropped to zer0 causing use after free.
>
> The flow is the following,
>
> while ((skb = skb_peek(&psock->ingress_skb))
> sk_psock_handle_Skb(psock, skb, ..., ingress)
> if (!ingress) ...
> sk_psock_skb_ingress
> sk_psock_skb_ingress_enqueue(skb)
> msg->skb = skb
> sk_psock_queue_msg(psock, msg)
> skb_dequeue(&psock->ingress_skb)
>
> [...]
Here is the summary with links:
- [bpf] bpf: sockmap, fix skb refcnt race after locking changes
https://git.kernel.org/bpf/bpf/c/a454d84ee20b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-09-04 8:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 20:21 [PATCH bpf] bpf: sockmap, fix skb refcnt race after locking changes John Fastabend
2023-09-01 21:20 ` Jiri Olsa
2023-09-01 21:24 ` Eduard Zingerman
2023-09-02 17:28 ` Jiri Olsa
2023-09-02 8:13 ` Xu Kuohai
2023-09-02 9:00 ` Simon Horman
2023-09-04 8:13 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169381522938.3122.223485705283897635.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cong.wang@bytedance.com \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olsajiri@gmail.com \
--cc=xukuohai@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).