* [PATCH iproute2-next] tc: fix several typos in netem's usage string
@ 2023-08-31 14:01 francois.michel
2023-08-31 16:05 ` Petr Machata
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: francois.michel @ 2023-08-31 14:01 UTC (permalink / raw)
Cc: netdev, francois.michel, stephen, petrm, dsahern, donald.hunter
From: François Michel <francois.michel@uclouvain.be>
Add missing brackets and surround brackets by single spaces
in the netem usage string.
Also state the P14 argument as optional.
Signed-off-by: François Michel <francois.michel@uclouvain.be>
---
tc/q_netem.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/tc/q_netem.c b/tc/q_netem.c
index 3be647ff..5d5aad80 100644
--- a/tc/q_netem.c
+++ b/tc/q_netem.c
@@ -24,20 +24,20 @@ static void explain(void)
{
fprintf(stderr,
"Usage: ... netem [ limit PACKETS ]\n"
- " [ delay TIME [ JITTER [CORRELATION]]]\n"
+ " [ delay TIME [ JITTER [ CORRELATION ] ] ]\n"
" [ distribution {uniform|normal|pareto|paretonormal} ]\n"
- " [ corrupt PERCENT [CORRELATION]]\n"
- " [ duplicate PERCENT [CORRELATION]]\n"
- " [ loss random PERCENT [CORRELATION]]\n"
- " [ loss state P13 [P31 [P32 [P23 P14]]]\n"
- " [ loss gemodel PERCENT [R [1-H [1-K]]]\n"
+ " [ corrupt PERCENT [ CORRELATION ] ]\n"
+ " [ duplicate PERCENT [ CORRELATION ] ]\n"
+ " [ loss random PERCENT [ CORRELATION ] ]\n"
+ " [ loss state P13 [ P31 [ P32 [ P23 [ P14 ] ] ] ] ]\n"
+ " [ loss gemodel PERCENT [ R [ 1-H [ 1-K ] ] ] ]\n"
" [ seed SEED ]\n"
" [ ecn ]\n"
- " [ reorder PERCENT [CORRELATION] [ gap DISTANCE ]]\n"
- " [ rate RATE [PACKETOVERHEAD] [CELLSIZE] [CELLOVERHEAD]]\n"
- " [ slot MIN_DELAY [MAX_DELAY] [packets MAX_PACKETS] [bytes MAX_BYTES]]\n"
+ " [ reorder PERCENT [ CORRELATION ] [ gap DISTANCE ] ]\n"
+ " [ rate RATE [ PACKETOVERHEAD ] [ CELLSIZE ] [ CELLOVERHEAD ] ]\n"
+ " [ slot MIN_DELAY [ MAX_DELAY ] [ packets MAX_PACKETS ] [ bytes MAX_BYTES ] ]\n"
" [ slot distribution {uniform|normal|pareto|paretonormal|custom}\n"
- " DELAY JITTER [packets MAX_PACKETS] [bytes MAX_BYTES]]\n");
+ " DELAY JITTER [ packets MAX_PACKETS ] [ bytes MAX_BYTES ] ]\n");
}
static void explain1(const char *arg)
base-commit: 865dd3ab1580092221c73317a844ee65f032c9e8
--
2.41.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH iproute2-next] tc: fix several typos in netem's usage string
2023-08-31 14:01 [PATCH iproute2-next] tc: fix several typos in netem's usage string francois.michel
@ 2023-08-31 16:05 ` Petr Machata
2023-08-31 16:17 ` Donald Hunter
2023-09-11 15:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Petr Machata @ 2023-08-31 16:05 UTC (permalink / raw)
To: francois.michel; +Cc: netdev, stephen, petrm, dsahern, donald.hunter
francois.michel@uclouvain.be writes:
> From: François Michel <francois.michel@uclouvain.be>
>
> Add missing brackets and surround brackets by single spaces
> in the netem usage string.
> Also state the P14 argument as optional.
>
> Signed-off-by: François Michel <francois.michel@uclouvain.be>
Many thanks!
Reviewed-by: Petr Machata <petrm@nvidia.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH iproute2-next] tc: fix several typos in netem's usage string
2023-08-31 14:01 [PATCH iproute2-next] tc: fix several typos in netem's usage string francois.michel
2023-08-31 16:05 ` Petr Machata
@ 2023-08-31 16:17 ` Donald Hunter
2023-09-11 15:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Donald Hunter @ 2023-08-31 16:17 UTC (permalink / raw)
To: francois.michel; +Cc: netdev, stephen, petrm, dsahern
francois.michel@uclouvain.be writes:
> From: François Michel <francois.michel@uclouvain.be>
>
> Add missing brackets and surround brackets by single spaces
> in the netem usage string.
> Also state the P14 argument as optional.
>
> Signed-off-by: François Michel <francois.michel@uclouvain.be>
Reviewed-by: Donald Hunter <donald.hunter@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH iproute2-next] tc: fix several typos in netem's usage string
2023-08-31 14:01 [PATCH iproute2-next] tc: fix several typos in netem's usage string francois.michel
2023-08-31 16:05 ` Petr Machata
2023-08-31 16:17 ` Donald Hunter
@ 2023-09-11 15:50 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-09-11 15:50 UTC (permalink / raw)
To: =?utf-8?q?Fran=C3=A7ois_Michel_=3Cfrancois=2Emichel=40uclouvain=2Ebe=3E?=
Cc: netdev, stephen, petrm, dsahern, donald.hunter
Hello:
This patch was applied to iproute2/iproute2-next.git (main)
by David Ahern <dsahern@kernel.org>:
On Thu, 31 Aug 2023 16:01:32 +0200 you wrote:
> From: François Michel <francois.michel@uclouvain.be>
>
> Add missing brackets and surround brackets by single spaces
> in the netem usage string.
> Also state the P14 argument as optional.
>
> Signed-off-by: François Michel <francois.michel@uclouvain.be>
>
> [...]
Here is the summary with links:
- [iproute2-next] tc: fix several typos in netem's usage string
https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=dd5b1f585bf6
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-09-11 15:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-31 14:01 [PATCH iproute2-next] tc: fix several typos in netem's usage string francois.michel
2023-08-31 16:05 ` Petr Machata
2023-08-31 16:17 ` Donald Hunter
2023-09-11 15:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).