From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5C2A38BB2; Tue, 19 Sep 2023 08:40:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 55EA9C433CA; Tue, 19 Sep 2023 08:40:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695112822; bh=Omy2LUg3uWH1pkOVY4vjdkn5QW6igyJTSPgKd0JcqqA=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=NabwgZalixdVnMCJQGMY5fHyowm94ENXgA9GQpnn0eqYrBXHp6meiXaFdiCMtU6RL hawFjKZelXREnGLpBm4SZbXxfUQ2sMN6hUzm6VrVSLkhCTwAszul/hkmO1KbwZzuYj N1ElyvnGX0zBi5rKztKHmx84J+zdfVp7QtMPCuhxEInF7eREv0BIiKNXND1q4aWFrG 1glOcYf/PvfxBSATEKH5el1w/fF5aWx/FIx47KIFLo4MBY/h43dQrmP/J08KFdOlRt 3TT/pcuia0tmo4gvhDinLFfTAi9ZKKv1VYthquugVRHFLce5HLQjMz6cohfSdzvEk3 cKrY0d1Omp21w== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 3955FE11F4A; Tue, 19 Sep 2023 08:40:22 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH v2] net: stmmac: fix incorrect rxq|txq_stats reference From: patchwork-bot+netdevbpf@kernel.org Message-Id: <169511282223.26432.8274174696059034896.git-patchwork-notify@kernel.org> Date: Tue, 19 Sep 2023 08:40:22 +0000 References: <20230917165328.3403-1-jszhang@kernel.org> In-Reply-To: <20230917165328.3403-1-jszhang@kernel.org> To: Jisheng Zhang Cc: peppe.cavallaro@st.com, alexandre.torgue@foss.st.com, joabreu@synopsys.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, mcoquelin.stm32@gmail.com, wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-stm32@st-md-mailman.stormreply.com, johannes@sipsolutions.net, u.kleine-koenig@pengutronix.de Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni : On Mon, 18 Sep 2023 00:53:28 +0800 you wrote: > commit 133466c3bbe1 ("net: stmmac: use per-queue 64 bit statistics > where necessary") caused one regression as found by Uwe, the backtrace > looks like: > > INFO: trying to register non-static key. > The code is fine but needs lockdep annotation, or maybe > you didn't initialize this object before use? > turning off the locking correctness validator. > CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.5.0-rc1-00449-g133466c3bbe1-dirty #21 > Hardware name: STM32 (Device Tree Support) > unwind_backtrace from show_stack+0x18/0x1c > show_stack from dump_stack_lvl+0x60/0x90 > dump_stack_lvl from register_lock_class+0x98c/0x99c > register_lock_class from __lock_acquire+0x74/0x293c > __lock_acquire from lock_acquire+0x134/0x398 > lock_acquire from stmmac_get_stats64+0x2ac/0x2fc > stmmac_get_stats64 from dev_get_stats+0x44/0x130 > dev_get_stats from rtnl_fill_stats+0x38/0x120 > rtnl_fill_stats from rtnl_fill_ifinfo+0x834/0x17f4 > rtnl_fill_ifinfo from rtmsg_ifinfo_build_skb+0xc0/0x144 > rtmsg_ifinfo_build_skb from rtmsg_ifinfo+0x50/0x88 > rtmsg_ifinfo from __dev_notify_flags+0xc0/0xec > __dev_notify_flags from dev_change_flags+0x50/0x5c > dev_change_flags from ip_auto_config+0x2f4/0x1260 > ip_auto_config from do_one_initcall+0x70/0x35c > do_one_initcall from kernel_init_freeable+0x2ac/0x308 > kernel_init_freeable from kernel_init+0x1c/0x138 > kernel_init from ret_from_fork+0x14/0x2c > > [...] Here is the summary with links: - [v2] net: stmmac: fix incorrect rxq|txq_stats reference https://git.kernel.org/netdev/net/c/8070274b472e You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html