From: patchwork-bot+netdevbpf@kernel.org
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: lars.povlsen@microchip.com, horatiu.vultur@microchip.com,
Steen.Hegelund@microchip.com, daniel.machon@microchip.com,
UNGLinuxDriver@microchip.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] net: microchip: sparx5: clean up error checking in vcap_show_admin()
Date: Tue, 03 Oct 2023 14:20:24 +0000 [thread overview]
Message-ID: <169634282481.20237.11023023965900224021.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <b88eba86-9488-4749-a896-7c7050132e7b@moroto.mountain>
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 8 Sep 2023 10:03:37 +0300 you wrote:
> The vcap_decode_rule() never returns NULL. There is no need to check
> for that. This code assumes that if it did return NULL we should
> end abruptly and return success. It is confusing. Fix the check to
> just be if (IS_ERR()) instead of if (IS_ERR_OR_NULL()).
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/r/202309070831.hTvj9ekP-lkp@intel.com/
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
>
> [...]
Here is the summary with links:
- [net-next] net: microchip: sparx5: clean up error checking in vcap_show_admin()
https://git.kernel.org/netdev/net-next/c/788f63c4dc17
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-10-03 14:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-08 7:03 [PATCH net-next] net: microchip: sparx5: clean up error checking in vcap_show_admin() Dan Carpenter
2023-09-08 7:48 ` Simon Horman
2023-09-08 8:27 ` Daniel Machon
2023-10-03 14:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169634282481.20237.11023023965900224021.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=dan.carpenter@linaro.org \
--cc=daniel.machon@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horatiu.vultur@microchip.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=lars.povlsen@microchip.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).