From: patchwork-bot+netdevbpf@kernel.org
To: Benjamin Poirier <bpoirier@nvidia.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, dsahern@kernel.org,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
amcohen@nvidia.com, idosch@nvidia.com
Subject: Re: [PATCH net] ipv4: Set offload_failed flag in fibmatch results
Date: Wed, 04 Oct 2023 18:50:25 +0000 [thread overview]
Message-ID: <169644542550.13943.9248162999887305594.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20230926182730.231208-1-bpoirier@nvidia.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 26 Sep 2023 14:27:30 -0400 you wrote:
> Due to a small omission, the offload_failed flag is missing from ipv4
> fibmatch results. Make sure it is set correctly.
>
> The issue can be witnessed using the following commands:
> echo "1 1" > /sys/bus/netdevsim/new_device
> ip link add dummy1 up type dummy
> ip route add 192.0.2.0/24 dev dummy1
> echo 1 > /sys/kernel/debug/netdevsim/netdevsim1/fib/fail_route_offload
> ip route add 198.51.100.0/24 dev dummy1
> ip route
> # 192.168.15.0/24 has rt_trap
> # 198.51.100.0/24 has rt_offload_failed
> ip route get 192.168.15.1 fibmatch
> # Result has rt_trap
> ip route get 198.51.100.1 fibmatch
> # Result differs from the route shown by `ip route`, it is missing
> # rt_offload_failed
> ip link del dev dummy1
> echo 1 > /sys/bus/netdevsim/del_device
>
> [...]
Here is the summary with links:
- [net] ipv4: Set offload_failed flag in fibmatch results
https://git.kernel.org/netdev/net/c/0add5c597f32
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-10-04 18:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-26 18:27 [PATCH net] ipv4: Set offload_failed flag in fibmatch results Benjamin Poirier
2023-10-02 12:59 ` Simon Horman
2023-10-02 14:15 ` David Ahern
2023-10-04 18:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169644542550.13943.9248162999887305594.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=amcohen@nvidia.com \
--cc=bpoirier@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).