From: Antoine Tenart <atenart@kernel.org>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, netdev@vger.kernel.org,
gregkh@linuxfoundation.org, mhocko@suse.com
Subject: Re: [RFC PATCH net-next 1/4] net-sysfs: remove rtnl_trylock from device attributes
Date: Thu, 19 Oct 2023 09:48:22 +0200 [thread overview]
Message-ID: <169770170247.433869.3027675693618433446@kwain> (raw)
In-Reply-To: <20231018111343.176ac1b9@hermes.local>
Quoting Stephen Hemminger (2023-10-18 20:13:43)
> On Wed, 18 Oct 2023 17:47:43 +0200
> Antoine Tenart <atenart@kernel.org> wrote:
>
> > +static inline struct kernfs_node *sysfs_rtnl_lock(struct kobject *kobj,
> > + struct attribute *attr,
> > + struct net_device *ndev)
> Still reviewing the details here.
Thanks!
> But inline on static functions is not the code policy in networking
> related code. The argument is compiler will inline anyway if useful.
Right, I'll fix that.
Antoine
next prev parent reply other threads:[~2023-10-19 7:48 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 15:47 [RFC PATCH net-next 0/4] net-sysfs: remove rtnl_trylock/restart_syscall use Antoine Tenart
2023-10-18 15:47 ` [RFC PATCH net-next 1/4] net-sysfs: remove rtnl_trylock from device attributes Antoine Tenart
2023-10-18 16:49 ` Greg KH
2023-10-19 8:13 ` Antoine Tenart
2023-10-19 15:37 ` Greg KH
2023-10-18 18:13 ` Stephen Hemminger
2023-10-19 7:48 ` Antoine Tenart [this message]
2025-01-02 22:36 ` Jakub Kicinski
2025-01-03 8:41 ` Eric Dumazet
2025-01-07 16:30 ` Antoine Tenart
2025-01-07 17:06 ` Jakub Kicinski
2025-01-16 13:36 ` Antoine Tenart
2025-01-16 23:42 ` Jakub Kicinski
2025-01-16 23:43 ` Jakub Kicinski
2025-01-17 8:26 ` Antoine Tenart
2023-10-18 15:47 ` [RFC PATCH net-next 2/4] net-sysfs: move queue attribute groups outside the default groups Antoine Tenart
2023-10-18 15:47 ` [RFC PATCH net-next 3/4] net-sysfs: prevent uncleared queues from being re-added Antoine Tenart
2023-10-18 15:47 ` [RFC PATCH net-next 4/4] net-sysfs: remove rtnl_trylock from queue attributes Antoine Tenart
2023-10-18 15:57 ` [RFC PATCH net-next 0/4] net-sysfs: remove rtnl_trylock/restart_syscall use Stephen Hemminger
2023-10-18 16:34 ` Antoine Tenart
2023-10-18 18:15 ` Stephen Hemminger
2023-10-19 7:47 ` Antoine Tenart
2023-10-19 14:54 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169770170247.433869.3027675693618433446@kwain \
--to=atenart@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=mhocko@suse.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox