* [PATCH] pds_core: add an error code check in pdsc_dl_info_get
@ 2023-10-19 8:33 Su Hui
2023-10-19 15:52 ` Nelson, Shannon
2023-10-21 0:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Su Hui @ 2023-10-19 8:33 UTC (permalink / raw)
To: shannon.nelson, brett.creeley, davem, edumazet, kuba, pabeni
Cc: Su Hui, netdev, linux-kernel, kernel-janitors
check the value of 'ret' after call 'devlink_info_version_stored_put'.
Signed-off-by: Su Hui <suhui@nfschina.com>
---
drivers/net/ethernet/amd/pds_core/devlink.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/amd/pds_core/devlink.c b/drivers/net/ethernet/amd/pds_core/devlink.c
index d9607033bbf2..09041f7fccaf 100644
--- a/drivers/net/ethernet/amd/pds_core/devlink.c
+++ b/drivers/net/ethernet/amd/pds_core/devlink.c
@@ -124,6 +124,8 @@ int pdsc_dl_info_get(struct devlink *dl, struct devlink_info_req *req,
snprintf(buf, sizeof(buf), "fw.slot_%d", i);
err = devlink_info_version_stored_put(req, buf,
fw_list.fw_names[i].fw_version);
+ if (err)
+ return err;
}
err = devlink_info_version_running_put(req,
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] pds_core: add an error code check in pdsc_dl_info_get
2023-10-19 8:33 [PATCH] pds_core: add an error code check in pdsc_dl_info_get Su Hui
@ 2023-10-19 15:52 ` Nelson, Shannon
2023-10-21 0:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Nelson, Shannon @ 2023-10-19 15:52 UTC (permalink / raw)
To: Su Hui, brett.creeley, davem, edumazet, kuba, pabeni
Cc: netdev, linux-kernel, kernel-janitors
On 10/19/2023 1:33 AM, Su Hui wrote:
>
> check the value of 'ret' after call 'devlink_info_version_stored_put'.
>
> Signed-off-by: Su Hui <suhui@nfschina.com>
Thanks.
Reviewed-by: Shannon Nelson <shannon.nelson@amd.com>
> ---
> drivers/net/ethernet/amd/pds_core/devlink.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ethernet/amd/pds_core/devlink.c b/drivers/net/ethernet/amd/pds_core/devlink.c
> index d9607033bbf2..09041f7fccaf 100644
> --- a/drivers/net/ethernet/amd/pds_core/devlink.c
> +++ b/drivers/net/ethernet/amd/pds_core/devlink.c
> @@ -124,6 +124,8 @@ int pdsc_dl_info_get(struct devlink *dl, struct devlink_info_req *req,
> snprintf(buf, sizeof(buf), "fw.slot_%d", i);
> err = devlink_info_version_stored_put(req, buf,
> fw_list.fw_names[i].fw_version);
> + if (err)
> + return err;
> }
>
> err = devlink_info_version_running_put(req,
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pds_core: add an error code check in pdsc_dl_info_get
2023-10-19 8:33 [PATCH] pds_core: add an error code check in pdsc_dl_info_get Su Hui
2023-10-19 15:52 ` Nelson, Shannon
@ 2023-10-21 0:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-10-21 0:50 UTC (permalink / raw)
To: Su Hui
Cc: shannon.nelson, brett.creeley, davem, edumazet, kuba, pabeni,
netdev, linux-kernel, kernel-janitors
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Thu, 19 Oct 2023 16:33:52 +0800 you wrote:
> check the value of 'ret' after call 'devlink_info_version_stored_put'.
>
> Signed-off-by: Su Hui <suhui@nfschina.com>
> ---
> drivers/net/ethernet/amd/pds_core/devlink.c | 2 ++
> 1 file changed, 2 insertions(+)
Here is the summary with links:
- pds_core: add an error code check in pdsc_dl_info_get
https://git.kernel.org/netdev/net-next/c/a1e4c334cbc9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-21 0:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-10-19 8:33 [PATCH] pds_core: add an error code check in pdsc_dl_info_get Su Hui
2023-10-19 15:52 ` Nelson, Shannon
2023-10-21 0:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).