From: patchwork-bot+netdevbpf@kernel.org
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, johannes.berg@intel.com, mpe@ellerman.id.au,
j@w1.fi, jiri@resnulli.us
Subject: Re: [PATCH net-next v2 0/6] net: deduplicate netdev name allocation
Date: Tue, 24 Oct 2023 20:10:27 +0000 [thread overview]
Message-ID: <169817822747.29692.6994871674872355452.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20231023152346.3639749-1-kuba@kernel.org>
Hello:
This series was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 23 Oct 2023 08:23:40 -0700 you wrote:
> After recent fixes we have even more duplicated code in netdev name
> allocation helpers. There are two complications in this code.
> First, __dev_alloc_name() clobbers its output arg even if allocation
> fails, forcing callers to do extra copies. Second as our experience in
> commit 55a5ec9b7710 ("Revert "net: core: dev_get_valid_name is now the same as dev_alloc_name_ns"") and
> commit 029b6d140550 ("Revert "net: core: maybe return -EEXIST in __dev_alloc_name"")
> taught us, user space is very sensitive to the exact error codes.
>
> [...]
Here is the summary with links:
- [net-next,v2,1/6] net: don't use input buffer of __dev_alloc_name() as a scratch space
https://git.kernel.org/netdev/net-next/c/bd07063dd11f
- [net-next,v2,2/6] net: make dev_alloc_name() call dev_prep_valid_name()
https://git.kernel.org/netdev/net-next/c/556c755a4d81
- [net-next,v2,3/6] net: reduce indentation of __dev_alloc_name()
https://git.kernel.org/netdev/net-next/c/9a810468126c
- [net-next,v2,4/6] net: trust the bitmap in __dev_alloc_name()
https://git.kernel.org/netdev/net-next/c/7ad17b04dc7b
- [net-next,v2,5/6] net: remove dev_valid_name() check from __dev_alloc_name()
https://git.kernel.org/netdev/net-next/c/70e1b14c1bcb
- [net-next,v2,6/6] net: remove else after return in dev_prep_valid_name()
https://git.kernel.org/netdev/net-next/c/ce4cfa2318af
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-10-24 20:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-23 15:23 [PATCH net-next v2 0/6] net: deduplicate netdev name allocation Jakub Kicinski
2023-10-23 15:23 ` [PATCH net-next v2 1/6] net: don't use input buffer of __dev_alloc_name() as a scratch space Jakub Kicinski
2023-10-23 15:23 ` [PATCH net-next v2 2/6] net: make dev_alloc_name() call dev_prep_valid_name() Jakub Kicinski
2023-10-23 15:23 ` [PATCH net-next v2 3/6] net: reduce indentation of __dev_alloc_name() Jakub Kicinski
2023-10-23 15:23 ` [PATCH net-next v2 4/6] net: trust the bitmap in __dev_alloc_name() Jakub Kicinski
2023-10-24 7:12 ` Jiri Pirko
2023-10-23 15:23 ` [PATCH net-next v2 5/6] net: remove dev_valid_name() check from __dev_alloc_name() Jakub Kicinski
2023-10-23 15:23 ` [PATCH net-next v2 6/6] net: remove else after return in dev_prep_valid_name() Jakub Kicinski
2023-10-24 20:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169817822747.29692.6994871674872355452.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=j@w1.fi \
--cc=jiri@resnulli.us \
--cc=johannes.berg@intel.com \
--cc=kuba@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).