From: patchwork-bot+netdevbpf@kernel.org
To: Eric Dumazet <edumazet@google.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
oliver.sang@intel.com, ncardwell@google.com, morleyd@google.com
Subject: Re: [PATCH net] tcp: fix fastopen code vs usec TS
Date: Fri, 03 Nov 2023 09:20:23 +0000 [thread overview]
Message-ID: <169900322353.11636.7052991589260368750.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20231031061945.2801972-1-edumazet@google.com>
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Tue, 31 Oct 2023 06:19:45 +0000 you wrote:
> After blamed commit, TFO client-ack-dropped-then-recovery-ms-timestamps
> packetdrill test failed.
>
> David Morley and Neal Cardwell started investigating and Neal pointed
> that we had :
>
> tcp_conn_request()
> tcp_try_fastopen()
> -> tcp_fastopen_create_child
> -> child = inet_csk(sk)->icsk_af_ops->syn_recv_sock()
> -> tcp_create_openreq_child()
> -> copy req_usec_ts from req:
> newtp->tcp_usec_ts = treq->req_usec_ts;
> // now the new TFO server socket always does usec TS, no matter
> // what the route options are...
> send_synack()
> -> tcp_make_synack()
> // disable tcp_rsk(req)->req_usec_ts if route option is not present:
> if (tcp_rsk(req)->req_usec_ts < 0)
> tcp_rsk(req)->req_usec_ts = dst_tcp_usec_ts(dst);
>
> [...]
Here is the summary with links:
- [net] tcp: fix fastopen code vs usec TS
https://git.kernel.org/netdev/net/c/cdbab6236605
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-11-03 9:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-31 6:19 [PATCH net] tcp: fix fastopen code vs usec TS Eric Dumazet
2023-10-31 12:03 ` Neal Cardwell
2023-11-03 9:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169900322353.11636.7052991589260368750.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=morleyd@google.com \
--cc=ncardwell@google.com \
--cc=netdev@vger.kernel.org \
--cc=oliver.sang@intel.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).