[PATCH v2] tg3: power down device only on SYSTEM_POWER_OFF

[PATCH v2] tg3: power down device only on SYSTEM_POWER_OFF

[George Shuklin]

Dell R650xs servers hangs on reboot if tg3 driver calls
tg3_power_down.

This happens only if network adapters (BCM5720 for R650xs) were
initialized using SNP (e.g. by booting ipxe.efi).

The actual problem is on Dell side, but this fix allows servers
to come back alive after reboot.

Signed-off-by: George Shuklin <george.shuklin@gmail.com>
Fixes: 2ca1c94ce0b6 ("tg3: Disable tg3 device on system reboot to avoid triggering AER")
---
 drivers/net/ethernet/broadcom/tg3.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
index 14b311196b8f..22b00912f7ac 100644
--- a/drivers/net/ethernet/broadcom/tg3.c
+++ b/drivers/net/ethernet/broadcom/tg3.c
@@ -18078,7 +18078,8 @@ static void tg3_shutdown(struct pci_dev *pdev)
 	if (netif_running(dev))
 		dev_close(dev);
 
-	tg3_power_down(tp);
+	if (system_state == SYSTEM_POWER_OFF)
+		tg3_power_down(tp);
 
 	rtnl_unlock();
 
-- 
2.42.0

Re: [PATCH v2] tg3: power down device only on SYSTEM_POWER_OFF

[Pavan Chebbi]

[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]

On Fri, Nov 3, 2023 at 5:21 PM George Shuklin <george.shuklin@gmail.com> wrote:
>
> Dell R650xs servers hangs on reboot if tg3 driver calls
> tg3_power_down.
>
> This happens only if network adapters (BCM5720 for R650xs) were
> initialized using SNP (e.g. by booting ipxe.efi).
>
> The actual problem is on Dell side, but this fix allows servers
> to come back alive after reboot.
>
> Signed-off-by: George Shuklin <george.shuklin@gmail.com>
> Fixes: 2ca1c94ce0b6 ("tg3: Disable tg3 device on system reboot to avoid triggering AER")
> ---
>  drivers/net/ethernet/broadcom/tg3.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/broadcom/tg3.c b/drivers/net/ethernet/broadcom/tg3.c
> index 14b311196b8f..22b00912f7ac 100644
> --- a/drivers/net/ethernet/broadcom/tg3.c
> +++ b/drivers/net/ethernet/broadcom/tg3.c
> @@ -18078,7 +18078,8 @@ static void tg3_shutdown(struct pci_dev *pdev)
>         if (netif_running(dev))
>                 dev_close(dev);
>
> -       tg3_power_down(tp);
> +       if (system_state == SYSTEM_POWER_OFF)
> +               tg3_power_down(tp);
>
>         rtnl_unlock();
>
> --
> 2.42.0
>
>

Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Thank you.

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]

Re: [PATCH v2] tg3: power down device only on SYSTEM_POWER_OFF

[Michael Chan]

[-- Attachment #1: Type: text/plain, Size: 727 bytes --]

On Fri, Nov 3, 2023 at 5:19 AM Pavan Chebbi <pavan.chebbi@broadcom.com> wrote:
>
> On Fri, Nov 3, 2023 at 5:21 PM George Shuklin <george.shuklin@gmail.com> wrote:
> >
> > Dell R650xs servers hangs on reboot if tg3 driver calls
> > tg3_power_down.
> >
> > This happens only if network adapters (BCM5720 for R650xs) were
> > initialized using SNP (e.g. by booting ipxe.efi).
> >
> > The actual problem is on Dell side, but this fix allows servers
> > to come back alive after reboot.
> >
> > Signed-off-by: George Shuklin <george.shuklin@gmail.com>
> > Fixes: 2ca1c94ce0b6 ("tg3: Disable tg3 device on system reboot to avoid triggering AER")

Thanks.

Reviewed-by: Michael Chan <michael.chan@broadcom.com>

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]

Re: [PATCH v2] tg3: power down device only on SYSTEM_POWER_OFF

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Fri,  3 Nov 2023 13:50:29 +0200 you wrote:
> Dell R650xs servers hangs on reboot if tg3 driver calls
> tg3_power_down.
> 
> This happens only if network adapters (BCM5720 for R650xs) were
> initialized using SNP (e.g. by booting ipxe.efi).
> 
> The actual problem is on Dell side, but this fix allows servers
> to come back alive after reboot.
> 
> [...]

Here is the summary with links:
  - [v2] tg3: power down device only on SYSTEM_POWER_OFF
    https://git.kernel.org/netdev/net/c/9fc3bc764334

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html