netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net] net: ti: icss-iep: fix setting counter value
@ 2023-11-07 12:00 Diogo Ivo
  2023-11-09 12:50 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Diogo Ivo @ 2023-11-07 12:00 UTC (permalink / raw)
  To: davem, edumazet, kuba, pabeni, horms, danishanwar, vigneshr,
	rogerq, grygorii.strashko, m-karicheri2
  Cc: Diogo Ivo, jan.kiszka, netdev, baocheng.su

Currently icss_iep_set_counter() writes the upper 32-bits of the
counter value to both the lower and upper counter registers, so
fix this by writing the appropriate value to the lower register.

Fixes: c1e0230eeaab ("net: ti: icss-iep: Add IEP driver")
Signed-off-by: Diogo Ivo <diogo.ivo@siemens.com>
---
 drivers/net/ethernet/ti/icssg/icss_iep.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/ti/icssg/icss_iep.c b/drivers/net/ethernet/ti/icssg/icss_iep.c
index 4cf2a52e4378..3025e9c18970 100644
--- a/drivers/net/ethernet/ti/icssg/icss_iep.c
+++ b/drivers/net/ethernet/ti/icssg/icss_iep.c
@@ -177,7 +177,7 @@ static void icss_iep_set_counter(struct icss_iep *iep, u64 ns)
 	if (iep->plat_data->flags & ICSS_IEP_64BIT_COUNTER_SUPPORT)
 		writel(upper_32_bits(ns), iep->base +
 		       iep->plat_data->reg_offs[ICSS_IEP_COUNT_REG1]);
-	writel(upper_32_bits(ns), iep->base + iep->plat_data->reg_offs[ICSS_IEP_COUNT_REG0]);
+	writel(lower_32_bits(ns), iep->base + iep->plat_data->reg_offs[ICSS_IEP_COUNT_REG0]);
 }
 
 static void icss_iep_update_to_next_boundary(struct icss_iep *iep, u64 start_ns);
-- 
2.42.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH net] net: ti: icss-iep: fix setting counter value
  2023-11-07 12:00 [PATCH net] net: ti: icss-iep: fix setting counter value Diogo Ivo
@ 2023-11-09 12:50 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-11-09 12:50 UTC (permalink / raw)
  To: Diogo Ivo
  Cc: davem, edumazet, kuba, pabeni, horms, danishanwar, vigneshr,
	rogerq, grygorii.strashko, m-karicheri2, jan.kiszka, netdev,
	baocheng.su

Hello:

This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Tue,  7 Nov 2023 12:00:36 +0000 you wrote:
> Currently icss_iep_set_counter() writes the upper 32-bits of the
> counter value to both the lower and upper counter registers, so
> fix this by writing the appropriate value to the lower register.
> 
> Fixes: c1e0230eeaab ("net: ti: icss-iep: Add IEP driver")
> Signed-off-by: Diogo Ivo <diogo.ivo@siemens.com>
> 
> [...]

Here is the summary with links:
  - [net] net: ti: icss-iep: fix setting counter value
    https://git.kernel.org/netdev/net/c/83b9dda8afa4

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-11-09 12:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-07 12:00 [PATCH net] net: ti: icss-iep: fix setting counter value Diogo Ivo
2023-11-09 12:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).