From: Rob Herring <robh@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"Gregory Clement" <gregory.clement@bootlin.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Christian Marangi" <ansuelsmth@gmail.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Florian Fainelli" <florian.fainelli@broadcom.com>,
"Conor Dooley" <conor+dt@kernel.org>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail.com>,
"Russell King" <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org,
"Vladimir Oltean" <olteanv@gmail.com>,
"Paolo Abeni" <pabeni@redhat.com>, "Andrew Lunn" <andrew@lunn.ch>,
devicetree@vger.kernel.org, "Marek Behún" <kabel@kernel.org>,
linux-kernel@vger.kernel.org,
"Eric Dumazet" <edumazet@google.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next v8 2/9] dt-bindings: net: mvusb: Fix up DSA example
Date: Mon, 13 Nov 2023 20:03:15 -0600 [thread overview]
Message-ID: <169992739589.301792.1356820385901192007.robh@kernel.org> (raw)
In-Reply-To: <20231114-marvell-88e6152-wan-led-v8-2-50688741691b@linaro.org>
On Tue, 14 Nov 2023 00:35:57 +0100, Linus Walleij wrote:
> When adding a proper schema for the Marvell mx88e6xxx switch,
> the scripts start complaining about this embedded example:
>
> dtschema/dtc warnings/errors:
> net/marvell,mvusb.example.dtb: switch@0: ports: '#address-cells'
> is a required property
> from schema $id: http://devicetree.org/schemas/net/dsa/marvell,mv88e6xxx.yaml#
> net/marvell,mvusb.example.dtb: switch@0: ports: '#size-cells'
> is a required property
> from schema $id: http://devicetree.org/schemas/net/dsa/marvell,mv88e6xxx.yaml#
>
> Fix this up by extending the example with those properties in
> the ports node.
>
> While we are at it, rename "ports" to "ethernet-ports" and rename
> "switch" to "ethernet-switch" as this is recommended practice.
>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Reviewed-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
> Documentation/devicetree/bindings/net/marvell,mvusb.yaml | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/net/marvell,mvusb.example.dtb: /example-0/usb/mdio@1/ethernet-switch@0: failed to match any schema with compatible: ['marvell,mv88e6190']
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231114-marvell-88e6152-wan-led-v8-2-50688741691b@linaro.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-11-14 2:03 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 23:35 [PATCH net-next v8 0/9] Create a binding for the Marvell MV88E6xxx DSA switches Linus Walleij
2023-11-13 23:35 ` [PATCH net-next v8 1/9] dt-bindings: net: dsa: Require ports or ethernet-ports Linus Walleij
2023-11-13 23:35 ` [PATCH net-next v8 2/9] dt-bindings: net: mvusb: Fix up DSA example Linus Walleij
2023-11-14 2:03 ` Rob Herring [this message]
2023-11-13 23:35 ` [PATCH net-next v8 3/9] ARM: dts: marvell: Fix some common switch mistakes Linus Walleij
2023-11-29 18:23 ` Vladimir Oltean
2023-11-13 23:35 ` [PATCH net-next v8 4/9] ARM: dts: nxp: " Linus Walleij
2023-11-29 18:22 ` Vladimir Oltean
2023-11-13 23:36 ` [PATCH net-next v8 5/9] ARM64: dts: marvell: " Linus Walleij
2023-11-29 18:18 ` Vladimir Oltean
2023-11-13 23:36 ` [PATCH net-next v8 6/9] dt-bindings: net: ethernet-switch: Accept special variants Linus Walleij
2023-11-14 21:47 ` Andrew Lunn
2023-11-16 18:41 ` Rob Herring
2023-11-13 23:36 ` [PATCH net-next v8 7/9] dt-bindings: marvell: Rewrite MV88E6xxx in schema Linus Walleij
2023-11-13 23:36 ` [PATCH net-next v8 8/9] ARM64: dts: Add special compatibles for the Turris Mox Linus Walleij
2023-11-13 23:36 ` [PATCH net-next v8 9/9] dt-bindings: marvell: Add Marvell MV88E6060 DSA schema Linus Walleij
2023-11-14 21:50 ` [PATCH net-next v8 0/9] Create a binding for the Marvell MV88E6xxx DSA switches Andrew Lunn
2023-11-15 9:50 ` Linus Walleij
2023-11-26 20:17 ` Linus Walleij
2023-11-26 21:06 ` Andrew Lunn
2023-11-27 14:20 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169992739589.301792.1356820385901192007.robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=florian.fainelli@broadcom.com \
--cc=gregory.clement@bootlin.com \
--cc=kabel@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox