From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next] IPv6 ifstats separation Date: Thu, 4 Oct 2018 10:26:42 -0700 Message-ID: <16b15e54-0a3c-4ee2-dbe1-b0963df10c26@gmail.com> References: <20181004164059.20214-1-ssuryaextr@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: Stephen Suryaputra , netdev@vger.kernel.org Return-path: Received: from mail-lj1-f195.google.com ([209.85.208.195]:43383 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727394AbeJEAVC (ORCPT ); Thu, 4 Oct 2018 20:21:02 -0400 Received: by mail-lj1-f195.google.com with SMTP id r8-v6so9087396ljc.10 for ; Thu, 04 Oct 2018 10:26:46 -0700 (PDT) In-Reply-To: <20181004164059.20214-1-ssuryaextr@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 10/04/2018 09:40 AM, Stephen Suryaputra wrote: > Separate IPv6 ifstats into the ones that are hit on fast path and > the ones that aren't. The ones that are not can be removed as needed > using sysctls. > > Signed-off-by: Stephen Suryaputra > --- > include/linux/ipv6.h | 3 + > include/net/if_inet6.h | 3 +- > include/net/ipv6.h | 28 ++- > include/net/snmp.h | 22 +++ > include/uapi/linux/ipv6.h | 3 + > include/uapi/linux/snmp.h | 3 +- > net/ipv6/addrconf.c | 380 +++++++++++++++++++++++++++++++++++--- > net/ipv6/addrconf_core.c | 3 +- > net/ipv6/proc.c | 57 +++++- > 9 files changed, 462 insertions(+), 40 deletions(-) This is a huge patch to review. It certainly deserves a changelog explaining why we should even review this stuff. What do we gain from this (huge and probably adding bugs) change exactly ??? Thanks.