Re: [PATCH net-next] net: phy: meson-gxl: enable edpd tunable support for G12A internal PHY

[Heiner Kallweit <hkallweit1@gmail.com>]

On 03.04.2023 22:24, Chris Healy wrote:
> On Mon, Apr 3, 2023 at 12:35 PM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>>
>> Enable EDPD PHY tunable support for the G12A internal PHY, reusing the
>> recently added tunable support in the smsc driver.
>>
>> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>> ---
>>  drivers/net/phy/meson-gxl.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c
>> index 3dea7c752..bb9b33b6b 100644
>> --- a/drivers/net/phy/meson-gxl.c
>> +++ b/drivers/net/phy/meson-gxl.c
>> @@ -210,6 +210,10 @@ static struct phy_driver meson_gxl_phy[] = {
>>                 .read_status    = lan87xx_read_status,
>>                 .config_intr    = smsc_phy_config_intr,
>>                 .handle_interrupt = smsc_phy_handle_interrupt,
>> +
>> +               .get_tunable    = smsc_phy_get_tunable,
>> +               .set_tunable    = smsc_phy_set_tunable,
>> +
>>                 .suspend        = genphy_suspend,
> Why add the empty lines before and after the two new lines?
> 
Just for readability, because these two entries belong together.
Sometimes it's a little hard to read if drivers have 10+ callbacks
in a flat list in different, arbitrary order.

>>                 .resume         = genphy_resume,
>>                 .read_mmd       = genphy_read_mmd_unsupported,
>> --
>> 2.40.0
>>