From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4BF9C43381 for ; Tue, 26 Mar 2019 02:41:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6FCAA20828 for ; Tue, 26 Mar 2019 02:41:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="uMLBj9CQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730559AbfCZClv (ORCPT ); Mon, 25 Mar 2019 22:41:51 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:46720 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726186AbfCZClv (ORCPT ); Mon, 25 Mar 2019 22:41:51 -0400 Received: by mail-pf1-f196.google.com with SMTP id 9so7341214pfj.13 for ; Mon, 25 Mar 2019 19:41:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=AtJkZSIHAKtR5UTddwTloLcA8UbLjLy4wXssSnU70pI=; b=uMLBj9CQvLcBUM4Yi0c+eqFEvOOTPyplmQEYCdG/9H3zH5VQ/hbYPWvh29KIaUEifS aey7H6BaHdV2ioA5k4fllJ8Juqi39sFy+uOAFcexmBhD6bZ5jhSri3zHAwfOJfu9GBYG BiSTg2Uc+JUxyoHNcuuPbJllxc4XipZAv3P7KT/wXgruNgh1gKDsmB4wjsq+dFvguBZr Z6wJY97TlXnH3g3VBtPA2nndTpKMiM8291QU69BgpalZiDHn7ccrZHEfuZCG4FNSdkwN Z6AmpyaPFYoab6VFxfj/zmbeGTUj9iZ9C3qx9eYFdKsaJ9zVwk/aECQUx+jQBLC40shc IG2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AtJkZSIHAKtR5UTddwTloLcA8UbLjLy4wXssSnU70pI=; b=CBGpM+WSM+4HqDntbzb4y7e/cloiuD0/sGN5ujzL0ge1m+nBe+1ipLBNVBdERsC9C3 pxBnloNVSn5wQPf60isnmkHepRhArad2SmqPjEAk5Hc9H6x7+t7HnKSbrBTyZHzkGhkS 4cMDRlZR4D9qqNO3LsQXXag21QlsHE4dDJ7kYufUnsIPd3o1uPTI7mb1VHWY5+0Z4QgN vzCdQ7fnokUczTiRc4QGMtiMQRIOre43JDXQD8nFTICBgXiW7Wly9n2cvxm5anX4SxiB dgDwJQMV9bpf7J5YUnfvqrgu64wRrbO1ku4fui5Ue5dRNvQo4s+PqHNORAGgv4cWyN0q 1xSA== X-Gm-Message-State: APjAAAUKPVBG91zgOAWzLKTJiwAjROFq4ajhB+zhIiNTOeee397xHlG+ ftykaT7bYM/NHKtcvDliVwU= X-Google-Smtp-Source: APXvYqxjzb4CAOZ7LK4nbHXT3HCfnTmrGQhX7rf8h6zK64u8hSuPsbX8LIYT1PNnRFGb5X0Xx07ozg== X-Received: by 2002:a65:625a:: with SMTP id q26mr26682025pgv.61.1553568110216; Mon, 25 Mar 2019 19:41:50 -0700 (PDT) Received: from [192.168.1.3] (ip68-101-123-102.oc.oc.cox.net. [68.101.123.102]) by smtp.gmail.com with ESMTPSA id u11sm20271912pfh.23.2019.03.25.19.41.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Mar 2019 19:41:49 -0700 (PDT) Subject: Re: [RFC PATCH net-next 08/13] net: dsa: sja1105: Add support for VLAN operations To: Vladimir Oltean , davem@davemloft.net, netdev@vger.kernel.org Cc: andrew@lunn.ch, vivien.didelot@gmail.com, linus.walleij@linaro.org References: <20190324032346.32394-1-olteanv@gmail.com> <20190324032346.32394-9-olteanv@gmail.com> From: Florian Fainelli Openpgp: preference=signencrypt Message-ID: <16d5d6fa-9a0f-3361-e8df-c78e0d22b7be@gmail.com> Date: Mon, 25 Mar 2019 19:41:48 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <20190324032346.32394-9-olteanv@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/23/2019 8:23 PM, Vladimir Oltean wrote: > VLAN filtering cannot be properly disabled in SJA1105. So in order to > emulate the "no VLAN awareness" behavior (not dropping traffic that is > tagged with a VID that isn't configured on the port), we need to hack > another switch feature: programmable TPID (which is 0x8100 for 802.1Q). > We are reprogramming the TPID to a bogus value (ETH_P_EDSA) which leaves > the switch thinking that all traffic is untagged, and therefore accepts > it. > > Under a vlan_filtering bridge, the proper TPID of ETH_P_8021Q is > installed again, and the switch starts identifying 802.1Q-tagged > traffic. > > Signed-off-by: Vladimir Oltean > --- [snip] > + for (i = 0; i < SJA1105_NUM_PORTS; i++) { > + struct net_device *bridge_dev; > + > + bridge_dev = dsa_to_port(ds, i)->bridge_dev; > + if (bridge_dev && > + bridge_dev != dsa_to_port(ds, port)->bridge_dev && > + br_vlan_enabled(bridge_dev) != enabled) { > + netdev_err(bridge_dev, > + "VLAN filtering is global to the switch!\n"); > + return -EINVAL; > + } We might want to move this to the DSA core at some point, I had some patches lying around for doing that but got side tracked with adding management support for b53/bcm_sf2. Not a big problem for now. Reviewed-by: Florian Fainelli -- Florian