* [PATCH net-next] sctp: process fwd tsn chunk only when prsctp is enabled
@ 2017-02-03 9:37 Xin Long
2017-02-03 14:09 ` Neil Horman
2017-02-06 16:57 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Xin Long @ 2017-02-03 9:37 UTC (permalink / raw)
To: network dev, linux-sctp
Cc: Marcelo Ricardo Leitner, Neil Horman, Vlad Yasevich, davem
This patch is to check if asoc->peer.prsctp_capable is set before
processing fwd tsn chunk, if not, it will return an ERROR to the
peer, just as rfc3758 section 3.3.1 demands.
Reported-by: Julian Cordes <julian.cordes@gmail.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
---
net/sctp/sm_statefuns.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c
index 782e579..d8798dd 100644
--- a/net/sctp/sm_statefuns.c
+++ b/net/sctp/sm_statefuns.c
@@ -3867,6 +3867,9 @@ sctp_disposition_t sctp_sf_eat_fwd_tsn(struct net *net,
return sctp_sf_pdiscard(net, ep, asoc, type, arg, commands);
}
+ if (!asoc->peer.prsctp_capable)
+ return sctp_sf_unk_chunk(net, ep, asoc, type, arg, commands);
+
/* Make sure that the FORWARD_TSN chunk has valid length. */
if (!sctp_chunk_length_valid(chunk, sizeof(struct sctp_fwdtsn_chunk)))
return sctp_sf_violation_chunklen(net, ep, asoc, type, arg,
@@ -3935,6 +3938,9 @@ sctp_disposition_t sctp_sf_eat_fwd_tsn_fast(
return sctp_sf_pdiscard(net, ep, asoc, type, arg, commands);
}
+ if (!asoc->peer.prsctp_capable)
+ return sctp_sf_unk_chunk(net, ep, asoc, type, arg, commands);
+
/* Make sure that the FORWARD_TSN chunk has a valid length. */
if (!sctp_chunk_length_valid(chunk, sizeof(struct sctp_fwdtsn_chunk)))
return sctp_sf_violation_chunklen(net, ep, asoc, type, arg,
--
2.1.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] sctp: process fwd tsn chunk only when prsctp is enabled
2017-02-03 9:37 [PATCH net-next] sctp: process fwd tsn chunk only when prsctp is enabled Xin Long
@ 2017-02-03 14:09 ` Neil Horman
2017-02-06 16:57 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Neil Horman @ 2017-02-03 14:09 UTC (permalink / raw)
To: Xin Long
Cc: network dev, linux-sctp, Marcelo Ricardo Leitner, Vlad Yasevich,
davem
On Fri, Feb 03, 2017 at 05:37:06PM +0800, Xin Long wrote:
> This patch is to check if asoc->peer.prsctp_capable is set before
> processing fwd tsn chunk, if not, it will return an ERROR to the
> peer, just as rfc3758 section 3.3.1 demands.
>
> Reported-by: Julian Cordes <julian.cordes@gmail.com>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
> ---
> net/sctp/sm_statefuns.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/net/sctp/sm_statefuns.c b/net/sctp/sm_statefuns.c
> index 782e579..d8798dd 100644
> --- a/net/sctp/sm_statefuns.c
> +++ b/net/sctp/sm_statefuns.c
> @@ -3867,6 +3867,9 @@ sctp_disposition_t sctp_sf_eat_fwd_tsn(struct net *net,
> return sctp_sf_pdiscard(net, ep, asoc, type, arg, commands);
> }
>
> + if (!asoc->peer.prsctp_capable)
> + return sctp_sf_unk_chunk(net, ep, asoc, type, arg, commands);
> +
> /* Make sure that the FORWARD_TSN chunk has valid length. */
> if (!sctp_chunk_length_valid(chunk, sizeof(struct sctp_fwdtsn_chunk)))
> return sctp_sf_violation_chunklen(net, ep, asoc, type, arg,
> @@ -3935,6 +3938,9 @@ sctp_disposition_t sctp_sf_eat_fwd_tsn_fast(
> return sctp_sf_pdiscard(net, ep, asoc, type, arg, commands);
> }
>
> + if (!asoc->peer.prsctp_capable)
> + return sctp_sf_unk_chunk(net, ep, asoc, type, arg, commands);
> +
> /* Make sure that the FORWARD_TSN chunk has a valid length. */
> if (!sctp_chunk_length_valid(chunk, sizeof(struct sctp_fwdtsn_chunk)))
> return sctp_sf_violation_chunklen(net, ep, asoc, type, arg,
> --
> 2.1.0
>
>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] sctp: process fwd tsn chunk only when prsctp is enabled
2017-02-03 9:37 [PATCH net-next] sctp: process fwd tsn chunk only when prsctp is enabled Xin Long
2017-02-03 14:09 ` Neil Horman
@ 2017-02-06 16:57 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2017-02-06 16:57 UTC (permalink / raw)
To: lucien.xin; +Cc: netdev, linux-sctp, marcelo.leitner, nhorman, vyasevich
From: Xin Long <lucien.xin@gmail.com>
Date: Fri, 3 Feb 2017 17:37:06 +0800
> This patch is to check if asoc->peer.prsctp_capable is set before
> processing fwd tsn chunk, if not, it will return an ERROR to the
> peer, just as rfc3758 section 3.3.1 demands.
>
> Reported-by: Julian Cordes <julian.cordes@gmail.com>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-02-06 16:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-02-03 9:37 [PATCH net-next] sctp: process fwd tsn chunk only when prsctp is enabled Xin Long
2017-02-03 14:09 ` Neil Horman
2017-02-06 16:57 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).