From mboxrd@z Thu Jan 1 00:00:00 1970 From: Edward Cree Subject: Re: [PATCH net-next 4/4] sfc: expose CTPIO stats on NICs that support them Date: Wed, 20 Dec 2017 11:29:32 +0000 Message-ID: <16e391db-b87f-7db5-4d6f-d8143bcddc49@solarflare.com> References: <62aabe1f-6148-922c-03fb-afec440b4a0e@solarflare.com> <20171219122019.7b3ac5d8@cakuba.netronome.com> <20171219.154256.506110072762756727.davem@davemloft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Cc: , To: David Miller , Return-path: Received: from dispatch1-us1.ppe-hosted.com ([148.163.129.52]:52944 "EHLO dispatch1-us1.ppe-hosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753218AbdLTL3h (ORCPT ); Wed, 20 Dec 2017 06:29:37 -0500 In-Reply-To: <20171219.154256.506110072762756727.davem@davemloft.net> Content-Language: en-GB Sender: netdev-owner@vger.kernel.org List-ID: On 19/12/17 20:42, David Miller wrote: > From: Jakub Kicinski > Date: Tue, 19 Dec 2017 12:20:36 -0800 > >> On Tue, 19 Dec 2017 17:06:36 +0000, Edward Cree wrote: >>> From: Bert Kenward >>> >>> While the Linux driver doesn't use CTPIO ('cut-through programmed I/O'), >>> other drivers on the same port might, so if we're responsible for >>> reporting per-port stats we need to include the CTPIO stats. >>> >>> Signed-off-by: Edward Cree >> FWIW this is missing a sign-off from Bert. > Edward, please fix this and resubmit. FWIW, our practice hitherto at Solarflare for patches written internally  has been to apply the SOB at the point of upstream submission; the  submitter is the person certifying (on behalf of the company) that the  patch is offered under a suitable license. The motion of the patch within the company is not tracked with SOBs since —  as works-for-hire — the copyrights are all owned by the company rather  than the patch author. If this is a problem we can start gathering SOBs from the authors for the  submission; but as I understand the DCoO that should not be necessary, and  it hasn't been considered a problem until recently. Please advise on how we should handle this in future. -Ed