From: patchwork-bot+netdevbpf@kernel.org
To: Baruch Siach <baruch@tkos.co.il>
Cc: alexandre.torgue@foss.st.com, joabreu@synopsys.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net 1/2] net: stmmac: fix rx budget limit check
Date: Wed, 15 Nov 2023 04:00:25 +0000 [thread overview]
Message-ID: <170002082579.14036.12947220513761250043.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <d9486296c3b6b12ab3a0515fcd47d56447a07bfc.1699897370.git.baruch@tkos.co.il>
Hello:
This series was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 13 Nov 2023 19:42:49 +0200 you wrote:
> The while loop condition verifies 'count < limit'. Neither value change
> before the 'count >= limit' check. As is this check is dead code. But
> code inspection reveals a code path that modifies 'count' and then goto
> 'drain_data' and back to 'read_again'. So there is a need to verify
> count value sanity after 'read_again'.
>
> Move 'read_again' up to fix the count limit check.
>
> [...]
Here is the summary with links:
- [net,1/2] net: stmmac: fix rx budget limit check
https://git.kernel.org/netdev/net/c/fa02de9e7588
- [net,2/2] net: stmmac: avoid rx queue overrun
https://git.kernel.org/netdev/net/c/b6cb4541853c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-11-15 4:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 17:42 [PATCH net 1/2] net: stmmac: fix rx budget limit check Baruch Siach
2023-11-13 17:42 ` [PATCH net 2/2] net: stmmac: avoid rx queue overrun Baruch Siach
2023-11-13 22:52 ` Jakub Kicinski
2023-11-14 8:08 ` Baruch Siach
2023-11-14 16:04 ` Serge Semin
2023-11-14 16:09 ` Baruch Siach
2023-11-14 11:25 ` [PATCH net 1/2] net: stmmac: fix rx budget limit check Serge Semin
2023-11-15 4:00 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170002082579.14036.12947220513761250043.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=baruch@tkos.co.il \
--cc=joabreu@synopsys.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).