From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5797180C for ; Wed, 15 Nov 2023 04:00:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fx5X1DEZ" Received: by smtp.kernel.org (Postfix) with ESMTPS id DA74AC433C9; Wed, 15 Nov 2023 04:00:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700020825; bh=E729oEFS23OgRRnSBOtsjFlpklq/fWND1XFtTohuimI=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=fx5X1DEZ1oZxnHqUuUxZZNR7/2Kv9m1PvH6cvlmB9TgLh1pp9W5AJngW/c9iQFGLW 3/fGdJcxz0qt7yZMjWDOnomwWbuMylD9v/dEOHaPsyrFrd1EX+PTjbjTJb/av+HV12 /5Bh2V3TyUwCqvIcgUjSdvUIGrDA943/gsP043EYbO/rNXKGCUIt4e7Aul7QXHkISa 2F0b+n0jfRi9oPBY5G17O/7Bo0aK/3oa3og8WUzb8LBcdorzk9O7fwpTviaNjEwhLb fhDSNRXNDsxAciif6jOjWv9rPhdT4H48ukzIxhJxEY2pBNcwwqqN5v90Y1BpEX7y4P Uc9NRgxQfJeag== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id C2A7CE1F670; Wed, 15 Nov 2023 04:00:25 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net 1/2] net: stmmac: fix rx budget limit check From: patchwork-bot+netdevbpf@kernel.org Message-Id: <170002082579.14036.12947220513761250043.git-patchwork-notify@kernel.org> Date: Wed, 15 Nov 2023 04:00:25 +0000 References: In-Reply-To: To: Baruch Siach Cc: alexandre.torgue@foss.st.com, joabreu@synopsys.com, netdev@vger.kernel.org Hello: This series was applied to netdev/net.git (main) by Jakub Kicinski : On Mon, 13 Nov 2023 19:42:49 +0200 you wrote: > The while loop condition verifies 'count < limit'. Neither value change > before the 'count >= limit' check. As is this check is dead code. But > code inspection reveals a code path that modifies 'count' and then goto > 'drain_data' and back to 'read_again'. So there is a need to verify > count value sanity after 'read_again'. > > Move 'read_again' up to fix the count limit check. > > [...] Here is the summary with links: - [net,1/2] net: stmmac: fix rx budget limit check https://git.kernel.org/netdev/net/c/fa02de9e7588 - [net,2/2] net: stmmac: avoid rx queue overrun https://git.kernel.org/netdev/net/c/b6cb4541853c You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html