From: patchwork-bot+netdevbpf@kernel.org
To: Daniel Borkmann <daniel@iogearbox.net>
Cc: netdev@vger.kernel.org, security@ncsc.gov.uk,
gregkh@linuxfoundation.org, willemdebruijn.kernel@gmail.com,
torvalds@linux-foundation.org, stable@kernel.org
Subject: Re: [PATCH net v2] packet: Move reference count in packet_sock to atomic_long_t
Date: Mon, 04 Dec 2023 23:20:23 +0000 [thread overview]
Message-ID: <170173202339.29919.16182353251638504303.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20231201131021.19999-1-daniel@iogearbox.net>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 1 Dec 2023 14:10:21 +0100 you wrote:
> In some potential instances the reference count on struct packet_sock
> could be saturated and cause overflows which gets the kernel a bit
> confused. To prevent this, move to a 64-bit atomic reference count on
> 64-bit architectures to prevent the possibility of this type to overflow.
>
> Because we can not handle saturation, using refcount_t is not possible
> in this place. Maybe someday in the future if it changes it could be
> used. Also, instead of using plain atomic64_t, use atomic_long_t instead.
> 32-bit machines tend to be memory-limited (i.e. anything that increases
> a reference uses so much memory that you can't actually get to 2**32
> references). 32-bit architectures also tend to have serious problems
> with 64-bit atomics. Hence, atomic_long_t is the more natural solution.
>
> [...]
Here is the summary with links:
- [net,v2] packet: Move reference count in packet_sock to atomic_long_t
https://git.kernel.org/netdev/net/c/db3fadacaf0c
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-12-04 23:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 13:10 [PATCH net v2] packet: Move reference count in packet_sock to atomic_long_t Daniel Borkmann
2023-12-01 15:03 ` Willem de Bruijn
2023-12-01 15:12 ` Eric Dumazet
2023-12-01 23:02 ` Greg Kroah-Hartman
2023-12-04 23:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170173202339.29919.16182353251638504303.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=daniel@iogearbox.net \
--cc=gregkh@linuxfoundation.org \
--cc=netdev@vger.kernel.org \
--cc=security@ncsc.gov.uk \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).