From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C682FDB; Mon, 11 Dec 2023 21:43:38 -0800 (PST) Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-1fb9a22b4a7so3176367fac.3; Mon, 11 Dec 2023 21:43:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702359818; x=1702964618; h=date:subject:message-id:references:in-reply-to:cc:to:from :mime-version:content-transfer-encoding:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=xlNXDh7i+xuUPez0jMtT71+3pJcqu/L3WLkyBQcQido=; b=qzmHw853ph+44Xu55/l4fxNhVLAKXFTEcUGJ4ZHPn063Ec605uY7jdG2HqElHUY6ME IKZl6frbwSdYD35LSaC33dF+6yTEVqFsFKgsumy6q/QJDt7l+I2m92Bw8T6UOEqIF+t3 j4ed0WaOI5v5M6YZVnhUdyA/GlP5+UfcGrxDpLp5AQfN4gSfCoj0FEmgPmQsYDE+OuUo CembZ6JrM2OxK+m9WMZ8vUjXWV2g/flRNsGZLH3vRPtVZmxo96iojITekUIFr96pSPcp 5L0kPYKxxKWY+fvoRVA5GoIYgIANzNX9/GyM293x75j5W9qX9JsFNUjq4laO7RnJXydR s8zg== X-Gm-Message-State: AOJu0YxvrBjC9x0GJYDaxCJFgWPHE3Cluv6hTeqHihwG70I4iZNbtyTX MfAEzG1shei3HuuSsyMVfQ== X-Google-Smtp-Source: AGHT+IGoPIIkORhBOT+o92RHO+zrp9Iw9PWqvFVCTy8m9aKCvVQGCSO56hbPo+pUhcKvSm6k4S8Kgg== X-Received: by 2002:a05:6871:7391:b0:1fa:fc32:f081 with SMTP id na17-20020a056871739100b001fafc32f081mr6938652oac.25.1702359817776; Mon, 11 Dec 2023 21:43:37 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id hi7-20020a056870c98700b001faef8bb534sm2930685oab.22.2023.12.11.21.43.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 21:43:37 -0800 (PST) Received: (nullmailer pid 39728 invoked by uid 1000); Tue, 12 Dec 2023 05:43:35 -0000 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8bit Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Rob Herring To: Daniel Golle Cc: devicetree@vger.kernel.org, netdev@vger.kernel.org, Matthias Brugger , Sean Wang , Conor Dooley , Qingfang Deng , Philipp Zabel , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Alexander Couzens , Felix Fietkau , SkyLake Huang , Eric Dumazet , Mark Lee , Paolo Abeni , Andrew Lunn , linux-mediatek@lists.infradead.org, Lorenzo Bianconi , Vinod Koul , AngeloGioacchino Del Regno , Chunfeng Yun , Krzysztof Kozlowski , Heiner Kallweit , Rob Herring , John Crispin , linux-phy@lists.infradead.org, Kishon Vijay Abraham I , Jakub Kicinski , Russell King , "David S. Miller" In-Reply-To: References: Message-Id: <170235981390.39579.3867728590010297335.robh@kernel.org> Subject: Re: [RFC PATCH net-next v3 1/8] dt-bindings: phy: mediatek,xfi-pextp: add new bindings Date: Mon, 11 Dec 2023 23:43:35 -0600 On Tue, 12 Dec 2023 03:46:26 +0000, Daniel Golle wrote: > Add bindings for the MediaTek PEXTP Ethernet SerDes PHY found in the > MediaTek MT7988 SoC which can operate at various interfaces modes: > > * USXGMII > * 10GBase-R > * 5GBase-R > * 2500Base-X > * 1000Base-X > * Cisco SGMII (MAC side) > > Signed-off-by: Daniel Golle > --- > .../bindings/phy/mediatek,xfi-pextp.yaml | 80 +++++++++++++++++++ > 1 file changed, 80 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/mediatek,xfi-pextp.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/phy/mediatek,xfi-pextp.yaml:33:16: [error] string value is redundantly quoted with any quotes (quoted-strings) ./Documentation/devicetree/bindings/phy/mediatek,xfi-pextp.yaml:34:16: [error] string value is redundantly quoted with any quotes (quoted-strings) dtschema/dtc warnings/errors: Documentation/devicetree/bindings/phy/mediatek,xfi-pextp.example.dts:18:18: fatal error: dt-bindings/clock/mediatek,mt7988-clk.h: No such file or directory 18 | #include | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/phy/mediatek,xfi-pextp.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1424: dt_binding_check] Error 2 make: *** [Makefile:234: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/b875f693f6d4367a610a12ef324584f3bf3a1c1c.1702352117.git.daniel@makrotopia.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.