From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH] net: add error handling for kmem_cache_create Date: Mon, 11 Jun 2018 21:31:47 -0700 Message-ID: <17050ede-26b7-dfa5-91c5-e94da3e336e6@gmail.com> References: <1528777798-40722-1-git-send-email-jiazhouyang09@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , Wei Wang , Martin KaFai Lau , Kees Cook , Eric Dumazet , Florian Westphal , Joe Perches , linux-decnet-user@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: Zhouyang Jia Return-path: In-Reply-To: <1528777798-40722-1-git-send-email-jiazhouyang09@gmail.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 06/11/2018 09:29 PM, Zhouyang Jia wrote: > When kmem_cache_create fails, the lack of error-handling code may > cause unexpected results. > > This patch adds error-handling code after calling kmem_cache_create. > > Signed-off-by: Zhouyang Jia > --- > net/decnet/dn_route.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/net/decnet/dn_route.c b/net/decnet/dn_route.c > index e747650..2b743c7 100644 > --- a/net/decnet/dn_route.c > +++ b/net/decnet/dn_route.c > @@ -1861,6 +1861,9 @@ void __init dn_route_init(void) > dn_dst_ops.kmem_cachep = > kmem_cache_create("dn_dst_cache", sizeof(struct dn_route), 0, > SLAB_HWCACHE_ALIGN|SLAB_PANIC, NULL); > + if (!dn_dst_ops.kmem_cachep) > + panic("Failed to create dn_dst_cache cache\n"); > + Not needed, since SLAB_PANIC would have paniced the box earlier. > dst_entries_init(&dn_dst_ops); > timer_setup(&dn_route_timer, dn_dst_check_expire, 0); > dn_route_timer.expires = jiffies + decnet_dst_gc_interval * HZ; >