From: patchwork-bot+netdevbpf@kernel.org
To: Salvatore Dipietro <dipiets@amazon.com>
Cc: edumazet@google.com, davem@davemloft.net, dsahern@kernel.org,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
blakgeof@amazon.com, alisaidi@amazon.com, benh@amazon.com,
dipietro.salvatore@gmail.com
Subject: Re: [PATCH v4] tcp: Add memory barrier to tcp_push()
Date: Tue, 23 Jan 2024 09:50:25 +0000 [thread overview]
Message-ID: <170600342579.26307.3816738058418886684.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240119190133.43698-1-dipiets@amazon.com>
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Fri, 19 Jan 2024 11:01:33 -0800 you wrote:
> On CPUs with weak memory models, reads and updates performed by tcp_push
> to the sk variables can get reordered leaving the socket throttled when
> it should not. The tasklet running tcp_wfree() may also not observe the
> memory updates in time and will skip flushing any packets throttled by
> tcp_push(), delaying the sending. This can pathologically cause 40ms
> extra latency due to bad interactions with delayed acks.
>
> [...]
Here is the summary with links:
- [v4] tcp: Add memory barrier to tcp_push()
https://git.kernel.org/netdev/net/c/7267e8dcad6b
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-01-23 9:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-19 19:01 [PATCH v4] tcp: Add memory barrier to tcp_push() Salvatore Dipietro
2024-01-19 19:13 ` Eric Dumazet
2024-01-22 14:40 ` Paolo Abeni
2024-01-23 9:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170600342579.26307.3816738058418886684.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=alisaidi@amazon.com \
--cc=benh@amazon.com \
--cc=blakgeof@amazon.com \
--cc=davem@davemloft.net \
--cc=dipietro.salvatore@gmail.com \
--cc=dipiets@amazon.com \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox