From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 077EF15A8 for ; Wed, 24 Jan 2024 01:30:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706059831; cv=none; b=QVzw5ns5T78SeOLnsMqmnTMvOz8AWxzGauF0t0JsLgc/L4po6n6o3IBLjsi8QCvrDpsNza684YLYbUlhG1ZKTXowxOoabNEpXEvRfcVb8NnNCbghnsiDXXM4WLlhVh5B3o52qGr4WGP7arBma8RGGrJi56L9JeAjhvqAg4nrph4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706059831; c=relaxed/simple; bh=VpZoUQ5t4BVqm8q9Sw48MGLF8Us8dfWTXEnva3UDeGg=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=hlt15cDH1GaNLyZrwrKdNzvGEpnIHdzUc/wp2qn3eWqFf1TTJVa2XJ7lUk5dFWHlJmspo9RtFz4Otmw3GAIbCOoIU1aVA4UGUrw222BMOyYoaObbyqs4dPC4oNB4P3x9ReklYz7jLrPxRkchZe300pse8CaDFj7T0RoCfoO4f1E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=FIOpcHba; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FIOpcHba" Received: by smtp.kernel.org (Postfix) with ESMTPS id 83898C433B1; Wed, 24 Jan 2024 01:30:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706059830; bh=VpZoUQ5t4BVqm8q9Sw48MGLF8Us8dfWTXEnva3UDeGg=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=FIOpcHbaVpNtpL2rM4bhSUm7WPYTUrznyr04CgSW48i2p6Wo/AnZTDg2GUoUCZQpx Xu7Z7NSB8wf7MAeyFtpca0rpCD2fhz1X8JF13hwZm+Plaj0TL5UdZLwBds/uSmIJBQ 5c+MxIV6o8QXjXnrB6rPvWAJEuEwfidh1UDNSi4nrIZN4ZAWCx2h1wYRgmNevVx0zz FdmmSjxYdWnIE08qDkQgFmT8Oyi2HMS40/DktxmaVe8sf++FBfJyus00x2SqPrgVhZ 92gwWd85So5kqQypqf6r4CuRShCcvspDDNlzNqbbodTY9yek6UrkkRpn6CRkF3uvis XArXqkhT3Hrjg== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 680B4DFF769; Wed, 24 Jan 2024 01:30:30 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH net v2 1/2] Revert "net: macsec: use skb_ensure_writable_head_tail to expand the skb" From: patchwork-bot+netdevbpf@kernel.org Message-Id: <170605983042.14933.14640605615298216416.git-patchwork-notify@kernel.org> Date: Wed, 24 Jan 2024 01:30:30 +0000 References: <20240118191811.50271-1-rrameshbabu@nvidia.com> In-Reply-To: <20240118191811.50271-1-rrameshbabu@nvidia.com> To: Rahul Rameshbabu Cc: netdev@vger.kernel.org, gal@nvidia.com, kuba@kernel.org, pabeni@redhat.com, edumazet@google.com, radu-nicolae.pirea@oss.nxp.com, davem@davemloft.net, sd@queasysnail.net Hello: This series was applied to netdev/net.git (main) by Jakub Kicinski : On Thu, 18 Jan 2024 11:18:06 -0800 you wrote: > This reverts commit b34ab3527b9622ca4910df24ff5beed5aa66c6b5. > > Using skb_ensure_writable_head_tail without a call to skb_unshare causes > the MACsec stack to operate on the original skb rather than a copy in the > macsec_encrypt path. This causes the buffer to be exceeded in space, and > leads to warnings generated by skb_put operations. Opting to revert this > change since skb_copy_expand is more efficient than > skb_ensure_writable_head_tail followed by a call to skb_unshare. > > [...] Here is the summary with links: - [net,v2,1/2] Revert "net: macsec: use skb_ensure_writable_head_tail to expand the skb" https://git.kernel.org/netdev/net/c/3222bc997a24 - [net,v2,2/2] net: macsec: Only require headroom/tailroom from offload implementer if .mdo_insert_tx_tag is implemented (no matching commit) You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html