* [PATCH net-next] mlxsw: remove I2C_CLASS_HWMON from drivers w/o detect and address_list
@ 2024-01-27 15:08 Heiner Kallweit
2024-01-28 14:18 ` Ido Schimmel
2024-01-31 2:00 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Heiner Kallweit @ 2024-01-27 15:08 UTC (permalink / raw)
To: Ido Schimmel, Petr Machata, David Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: netdev@vger.kernel.org, linux-i2c@vger.kernel.org
Class-based I2C probing requires detect() and address_list to be
set in the I2C client driver, see checks in i2c_detect().
It's misleading to declare I2C_CLASS_HWMON support if this
precondition isn't met.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/net/ethernet/mellanox/mlxsw/minimal.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlxsw/minimal.c b/drivers/net/ethernet/mellanox/mlxsw/minimal.c
index 6b98c3287..f0ceb196a 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/minimal.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/minimal.c
@@ -708,7 +708,6 @@ static const struct i2c_device_id mlxsw_m_i2c_id[] = {
static struct i2c_driver mlxsw_m_i2c_driver = {
.driver.name = "mlxsw_minimal",
- .class = I2C_CLASS_HWMON,
.id_table = mlxsw_m_i2c_id,
};
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net-next] mlxsw: remove I2C_CLASS_HWMON from drivers w/o detect and address_list
2024-01-27 15:08 [PATCH net-next] mlxsw: remove I2C_CLASS_HWMON from drivers w/o detect and address_list Heiner Kallweit
@ 2024-01-28 14:18 ` Ido Schimmel
2024-01-31 2:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Ido Schimmel @ 2024-01-28 14:18 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Petr Machata, David Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, netdev@vger.kernel.org, linux-i2c@vger.kernel.org,
vadimp
On Sat, Jan 27, 2024 at 04:08:18PM +0100, Heiner Kallweit wrote:
> Class-based I2C probing requires detect() and address_list to be
> set in the I2C client driver, see checks in i2c_detect().
> It's misleading to declare I2C_CLASS_HWMON support if this
> precondition isn't met.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
> ---
> drivers/net/ethernet/mellanox/mlxsw/minimal.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/minimal.c b/drivers/net/ethernet/mellanox/mlxsw/minimal.c
> index 6b98c3287..f0ceb196a 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/minimal.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/minimal.c
> @@ -708,7 +708,6 @@ static const struct i2c_device_id mlxsw_m_i2c_id[] = {
>
> static struct i2c_driver mlxsw_m_i2c_driver = {
> .driver.name = "mlxsw_minimal",
> - .class = I2C_CLASS_HWMON,
> .id_table = mlxsw_m_i2c_id,
> };
>
> --
> 2.43.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net-next] mlxsw: remove I2C_CLASS_HWMON from drivers w/o detect and address_list
2024-01-27 15:08 [PATCH net-next] mlxsw: remove I2C_CLASS_HWMON from drivers w/o detect and address_list Heiner Kallweit
2024-01-28 14:18 ` Ido Schimmel
@ 2024-01-31 2:00 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-01-31 2:00 UTC (permalink / raw)
To: Heiner Kallweit
Cc: idosch, petrm, davem, edumazet, kuba, pabeni, netdev, linux-i2c
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sat, 27 Jan 2024 16:08:18 +0100 you wrote:
> Class-based I2C probing requires detect() and address_list to be
> set in the I2C client driver, see checks in i2c_detect().
> It's misleading to declare I2C_CLASS_HWMON support if this
> precondition isn't met.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
>
> [...]
Here is the summary with links:
- [net-next] mlxsw: remove I2C_CLASS_HWMON from drivers w/o detect and address_list
https://git.kernel.org/netdev/net-next/c/ccf1445204a1
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-31 2:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-27 15:08 [PATCH net-next] mlxsw: remove I2C_CLASS_HWMON from drivers w/o detect and address_list Heiner Kallweit
2024-01-28 14:18 ` Ido Schimmel
2024-01-31 2:00 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).