From: Jay Vosburgh <jay.vosburgh@canonical.com>
To: Huazhong Tan <tanhuazhong@huawei.com>
Cc: davem@davemloft.net, kuba@kernel.org, jesse.brandeburg@intel.com,
vfalico@gmail.com, andrew@lunn.ch, elder@kernel.org,
netdev@vger.kernel.org, salil.mehta@huawei.com,
yisen.zhuang@huawei.com, huangdaode@huawei.com,
linuxarm@openeuler.org, linuxarm@huawei.com,
Peng Li <lipeng321@huawei.com>
Subject: Re: [RESEND net-next 2/4] net: bonding: remove repeated word
Date: Tue, 30 Mar 2021 09:05:59 -0700 [thread overview]
Message-ID: <17079.1617120359@famine> (raw)
In-Reply-To: <1617089276-30268-3-git-send-email-tanhuazhong@huawei.com>
Huazhong Tan <tanhuazhong@huawei.com> wrote:
>From: Peng Li <lipeng321@huawei.com>
>
>Remove repeated word "that".
>
>Signed-off-by: Peng Li <lipeng321@huawei.com>
>Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
>---
> drivers/net/bonding/bond_alb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
>index c3091e0..3455f2c 100644
>--- a/drivers/net/bonding/bond_alb.c
>+++ b/drivers/net/bonding/bond_alb.c
>@@ -1098,7 +1098,7 @@ static void alb_fasten_mac_swap(struct bonding *bond, struct slave *slave1,
> * If @slave's permanent hw address is different both from its current
> * address and from @bond's address, then somewhere in the bond there's
> * a slave that has @slave's permanet address as its current address.
>- * We'll make sure that that slave no longer uses @slave's permanent address.
>+ * We'll make sure that slave no longer uses @slave's permanent address.
This is actually correct as written, but I can see that it's a
bit confusing. Rather than removing the second that, I'd suggest
changing it to "... make sure the other slave no longer uses ..." to be
clearer.
-J
---
-Jay Vosburgh, jay.vosburgh@canonical.com
next prev parent reply other threads:[~2021-03-30 16:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 7:27 [RESEND net-next 0/4] net: remove repeated words Huazhong Tan
2021-03-30 7:27 ` [RESEND net-next 1/4] net: i40e: " Huazhong Tan
2021-03-30 16:27 ` Randy Dunlap
2021-03-30 7:27 ` [RESEND net-next 2/4] net: bonding: remove repeated word Huazhong Tan
2021-03-30 16:05 ` Jay Vosburgh [this message]
2021-03-30 7:27 ` [RESEND net-next 3/4] net: phy: " Huazhong Tan
2021-03-30 13:36 ` Andrew Lunn
2021-03-30 7:27 ` [RESEND net-next 4/4] net: ipa: remove repeated words Huazhong Tan
2021-03-30 11:45 ` Alex Elder
2021-03-31 0:00 ` [RESEND net-next 0/4] net: " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17079.1617120359@famine \
--to=jay.vosburgh@canonical.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=elder@kernel.org \
--cc=huangdaode@huawei.com \
--cc=jesse.brandeburg@intel.com \
--cc=kuba@kernel.org \
--cc=linuxarm@huawei.com \
--cc=linuxarm@openeuler.org \
--cc=lipeng321@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=tanhuazhong@huawei.com \
--cc=vfalico@gmail.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).