From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: Re: [PATCH bpf-next 4/5] selftests/bpf: test_sockmap, fix data verification Date: Fri, 18 May 2018 09:49:20 -0700 Message-ID: <17089145-e63d-6610-80e6-dc313a7fecc2@gmail.com> References: <20180518071753.4768-1-bhole_prashant_q7@lab.ntt.co.jp> <20180518071753.4768-5-bhole_prashant_q7@lab.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: "David S . Miller" , Shuah Khan , netdev@vger.kernel.org To: Prashant Bhole , Alexei Starovoitov , Daniel Borkmann Return-path: Received: from mail-pl0-f65.google.com ([209.85.160.65]:33663 "EHLO mail-pl0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752328AbeERQtZ (ORCPT ); Fri, 18 May 2018 12:49:25 -0400 Received: by mail-pl0-f65.google.com with SMTP id n10-v6so4911470plp.0 for ; Fri, 18 May 2018 09:49:25 -0700 (PDT) In-Reply-To: <20180518071753.4768-5-bhole_prashant_q7@lab.ntt.co.jp> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 05/18/2018 12:17 AM, Prashant Bhole wrote: > When data verification is enabled, some tests fail because verification is done > incorrectly. Following changes fix it. > > - Identify the size of data block to be verified > - Reset verification counter when data block size is reached > - Fixed the value printed in case of verification failure > > Fixes: 16962b2404ac ("bpf: sockmap, add selftests") > Signed-off-by: Prashant Bhole > --- Thanks! Acked-by: John Fastabend