* [PATCH net v1 1/1] net: lan78xx: fix "softirq work is pending" error
@ 2024-02-26 11:08 Oleksij Rempel
2024-02-28 3:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Oleksij Rempel @ 2024-02-26 11:08 UTC (permalink / raw)
To: David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
Woojung Huh
Cc: Oleksij Rempel, kernel, linux-kernel, netdev, UNGLinuxDriver
Disable BH around the call to napi_schedule() to avoid following
error:
NOHZ tick-stop error: local softirq work is pending, handler #08!!!
Fixes: ec4c7e12396b ("lan78xx: Introduce NAPI polling support")
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
drivers/net/usb/lan78xx.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index 7d7e185d7fae..3ff430198512 100644
--- a/drivers/net/usb/lan78xx.c
+++ b/drivers/net/usb/lan78xx.c
@@ -1501,7 +1501,9 @@ static int lan78xx_link_reset(struct lan78xx_net *dev)
lan78xx_rx_urb_submit_all(dev);
+ local_bh_disable();
napi_schedule(&dev->napi);
+ local_bh_enable();
}
return 0;
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net v1 1/1] net: lan78xx: fix "softirq work is pending" error
2024-02-26 11:08 [PATCH net v1 1/1] net: lan78xx: fix "softirq work is pending" error Oleksij Rempel
@ 2024-02-28 3:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-02-28 3:20 UTC (permalink / raw)
To: Oleksij Rempel
Cc: davem, edumazet, kuba, pabeni, woojung.huh, kernel, linux-kernel,
netdev, UNGLinuxDriver
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 26 Feb 2024 12:08:20 +0100 you wrote:
> Disable BH around the call to napi_schedule() to avoid following
> error:
> NOHZ tick-stop error: local softirq work is pending, handler #08!!!
>
> Fixes: ec4c7e12396b ("lan78xx: Introduce NAPI polling support")
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
>
> [...]
Here is the summary with links:
- [net,v1,1/1] net: lan78xx: fix "softirq work is pending" error
https://git.kernel.org/netdev/net/c/e3d5d70cb483
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-02-28 3:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-26 11:08 [PATCH net v1 1/1] net: lan78xx: fix "softirq work is pending" error Oleksij Rempel
2024-02-28 3:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).