* [PATCH v2 net-next] devlink: Add comments to use netlink gen tool
@ 2024-03-10 14:55 William Tu
2024-03-11 8:35 ` Jiri Pirko
2024-03-11 23:20 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: William Tu @ 2024-03-10 14:55 UTC (permalink / raw)
To: netdev; +Cc: jiri, bodong, kuba, witu
Add the comment to remind people not to manually modify
the net/devlink/netlink_gen.c, but to use tools/net/ynl/ynl-regen.sh
to generate it.
Signed-off-by: William Tu <witu@nvidia.com>
Suggested-by: Jiri Pirko <jiri@nvidia.com>
---
v2: fix checkpatch error
---
include/uapi/linux/devlink.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/uapi/linux/devlink.h b/include/uapi/linux/devlink.h
index 130cae0d3e20..2da0c7eb6710 100644
--- a/include/uapi/linux/devlink.h
+++ b/include/uapi/linux/devlink.h
@@ -614,7 +614,10 @@ enum devlink_attr {
DEVLINK_ATTR_REGION_DIRECT, /* flag */
- /* add new attributes above here, update the policy in devlink.c */
+ /* Add new attributes above here, update the spec in
+ * Documentation/netlink/specs/devlink.yaml and re-generate
+ * net/devlink/netlink_gen.c.
+ */
__DEVLINK_ATTR_MAX,
DEVLINK_ATTR_MAX = __DEVLINK_ATTR_MAX - 1
--
2.38.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH v2 net-next] devlink: Add comments to use netlink gen tool
2024-03-10 14:55 [PATCH v2 net-next] devlink: Add comments to use netlink gen tool William Tu
@ 2024-03-11 8:35 ` Jiri Pirko
2024-03-11 23:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Pirko @ 2024-03-11 8:35 UTC (permalink / raw)
To: William Tu; +Cc: netdev, jiri, bodong, kuba
Sun, Mar 10, 2024 at 03:55:03PM CET, witu@nvidia.com wrote:
>Add the comment to remind people not to manually modify
>the net/devlink/netlink_gen.c, but to use tools/net/ynl/ynl-regen.sh
>to generate it.
>
>Signed-off-by: William Tu <witu@nvidia.com>
>Suggested-by: Jiri Pirko <jiri@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 net-next] devlink: Add comments to use netlink gen tool
2024-03-10 14:55 [PATCH v2 net-next] devlink: Add comments to use netlink gen tool William Tu
2024-03-11 8:35 ` Jiri Pirko
@ 2024-03-11 23:20 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-03-11 23:20 UTC (permalink / raw)
To: William Tu; +Cc: netdev, jiri, bodong, kuba
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Sun, 10 Mar 2024 16:55:03 +0200 you wrote:
> Add the comment to remind people not to manually modify
> the net/devlink/netlink_gen.c, but to use tools/net/ynl/ynl-regen.sh
> to generate it.
>
> Signed-off-by: William Tu <witu@nvidia.com>
> Suggested-by: Jiri Pirko <jiri@nvidia.com>
>
> [...]
Here is the summary with links:
- [v2,net-next] devlink: Add comments to use netlink gen tool
https://git.kernel.org/netdev/net-next/c/eaf657f7adba
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-11 23:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-03-10 14:55 [PATCH v2 net-next] devlink: Add comments to use netlink gen tool William Tu
2024-03-11 8:35 ` Jiri Pirko
2024-03-11 23:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).