Netdev List
 help / color / mirror / Atom feed
From: Antoine Tenart <atenart@kernel.org>
To: Nikolay Aleksandrov <razor@blackwall.org>,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com
Cc: steffen.klassert@secunet.com, willemdebruijn.kernel@gmail.com,
	netdev@vger.kernel.org, Willem de Bruijn <willemb@google.com>
Subject: Re: [PATCH net v2 1/4] udp: do not accept non-tunnel GSO skbs landing in a tunnel
Date: Wed, 20 Mar 2024 12:13:52 +0100	[thread overview]
Message-ID: <171093323212.5492.17032648986424979519@kwain> (raw)
In-Reply-To: <99098715-6b36-456a-869e-39f9b211a8bc@blackwall.org>

Quoting Nikolay Aleksandrov (2024-03-20 11:34:01)
> On 3/19/24 11:31, Antoine Tenart wrote:
> [snip]
> > @@ -163,6 +181,16 @@ static inline bool udp_unexpected_gso(struct sock *sk, struct sk_buff *skb)
> >           !udp_test_bit(ACCEPT_FRAGLIST, sk))
> >               return true;
> >   
> > +     /* GSO packets lacking the SKB_GSO_UDP_TUNNEL/_CUSM bits might still
> 
> s/CUSM/CSUM/

In the commit msg as well, thanks, will fix.

Antoine

  reply	other threads:[~2024-03-20 11:13 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-19  9:31 [PATCH net v2 0/4] gro: various fixes related to UDP tunnels Antoine Tenart
2024-03-19  9:31 ` [PATCH net v2 1/4] udp: do not accept non-tunnel GSO skbs landing in a tunnel Antoine Tenart
2024-03-20  2:41   ` Jakub Kicinski
2024-03-20 11:11     ` Antoine Tenart
2024-03-20 10:34   ` Nikolay Aleksandrov
2024-03-20 11:13     ` Antoine Tenart [this message]
2024-03-19  9:31 ` [PATCH net v2 2/4] gro: fix ownership transfer Antoine Tenart
2024-03-19 13:13   ` Willem de Bruijn
2024-03-19  9:31 ` [PATCH net v2 3/4] udp: do not transition UDP fraglist to unnecessary checksum Antoine Tenart
2024-03-19 13:38   ` Willem de Bruijn
2024-03-19 16:01     ` Antoine Tenart
2024-03-20 13:00       ` Willem de Bruijn
2024-03-20 15:08         ` Antoine Tenart
2024-03-20 20:43           ` Willem de Bruijn
2024-03-21  8:48             ` Antoine Tenart
2024-03-21 12:42               ` Paolo Abeni
2024-03-21 14:58               ` Willem de Bruijn
2024-03-21 17:22                 ` Antoine Tenart
2024-03-21 18:13                   ` Willem de Bruijn
2024-03-22 10:48                     ` Antoine Tenart
2024-03-19  9:31 ` [PATCH net v2 4/4] udp: prevent local UDP tunnel packets from being GROed Antoine Tenart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171093323212.5492.17032648986424979519@kwain \
    --to=atenart@kernel.org \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=razor@blackwall.org \
    --cc=steffen.klassert@secunet.com \
    --cc=willemb@google.com \
    --cc=willemdebruijn.kernel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox