From: Evgeniy Polyakov <zbr@ioremap.net>
To: Aaron Campbell <aaron@monkey.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jon DeVree <nuxi@vault24.org>
Subject: Re: [PATCH] connector: fix out-of-order cn_proc netlink message delivery
Date: Tue, 28 Jun 2016 15:56:05 +0300 [thread overview]
Message-ID: <1710991467118565@web17j.yandex.ru> (raw)
In-Reply-To: <1466773532-16596-1-git-send-email-aaron@monkey.org>
Hi Aaron
24.06.2016, 16:07, "Aaron Campbell" <aaron@monkey.org>:
> The proc connector messages include a sequence number, allowing userspace
> programs to detect lost messages. However, performing this detection is
> currently more difficult than necessary, since netlink messages can be
> delivered to the application out-of-order. To fix this, leave pre-emption
> disabled during cn_netlink_send(), and use GFP_NOWAIT.
>
> The following was written as a test case. Building the kernel w/ make -j32
> proved a reliable way to generate out-of-order cn_proc messages.
This is not actually about out-of-order sending which is impossible iirc,
but the way fork pushes messages into socket queue in parallel. What you've done
is syncing one more layer higher.
I'm not against this patch if you think it does fix some issues, but wording is not correct imo.
prev parent reply other threads:[~2016-06-28 13:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-24 13:05 [PATCH] connector: fix out-of-order cn_proc netlink message delivery Aaron Campbell
2016-06-28 12:49 ` David Miller
2016-06-28 12:56 ` Evgeniy Polyakov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1710991467118565@web17j.yandex.ru \
--to=zbr@ioremap.net \
--cc=aaron@monkey.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nuxi@vault24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).