From: Alexander Stein <alexander.stein@systec-electronic.com>
To: John Crispin <john@phrozen.org>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
andrew@lunn.ch, Mathias Kresin <openwrt@kresin.me>,
Hauke Mehrtens <Hauke.Mehrtens@lantiq.com>
Subject: Re: [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver
Date: Thu, 19 May 2016 08:57:57 +0200 [thread overview]
Message-ID: <1712340.89M2Ezzzk6@ws-stein> (raw)
In-Reply-To: <2a059454-279b-4ade-6f0e-837013bb323f@phrozen.org>
Hi John,
On Thursday 19 May 2016 06:50:56, John Crispin wrote:
> On 18/05/2016 18:24, Florian Fainelli wrote:
> > CC'ing Andrew, John,
>
> also CC'ing Matthias and Hauke. we have had a driver in OpenWrt/LEDE for
> several years that seems a little more complete than this one.
>
> https://git.lede-project.org/?p=source.git;a=blob;f=target/linux/lantiq/patc
> hes-4.4/0023-NET-PHY-adds-driver-for-lantiq-PHY11G.patch;h=93bb4275ec1d261f3
> 98afb8fdc879c1dd973f997;hb=HEAD
Thanks for the link, I wasn't aware of that patch. I like it in general, but
there are some things I'd like to get addressed first:
* vr9_gphy_of_reg_init() writes uncoditionally to led3h and led3l even on
PEf7071 which does not have this register at all
* Why is PHY_HAS_INTERRUPT commented out everywhere?
* ltq_phy_init and ltq_phy_exit can be simplified using phy_drivers_register
and phy_drivers_unregister
* A mdio_device_id table is missing
Best regards,
Alexander
next prev parent reply other threads:[~2016-05-19 6:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 16:03 [PATCH 1/1 RFC] net/phy: Add Lantiq PHY driver Alexander Stein
2016-05-18 16:24 ` Florian Fainelli
2016-05-18 17:01 ` Andrew Lunn
2016-05-19 7:05 ` Alexander Stein
2016-05-19 12:15 ` Andrew Lunn
2016-05-19 4:50 ` John Crispin
2016-05-19 6:57 ` Alexander Stein [this message]
2016-05-19 7:03 ` John Crispin
2016-05-19 7:28 ` Alexander Stein
2016-05-19 10:03 ` Mathias Kresin
2016-05-19 10:21 ` Alexander Stein
2016-05-23 9:12 ` Mehrtens, Hauke
2016-05-23 9:49 ` Alexander Stein
2016-05-23 10:07 ` Mathias Kresin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1712340.89M2Ezzzk6@ws-stein \
--to=alexander.stein@systec-electronic.com \
--cc=Hauke.Mehrtens@lantiq.com \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=openwrt@kresin.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).