netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [net Patch] octeontx2-pf: Fix transmit scheduler resource leak
@ 2024-04-04 11:24 Hariprasad Kelam
  2024-04-07 14:50 ` patchwork-bot+netdevbpf
  0 siblings, 1 reply; 2+ messages in thread
From: Hariprasad Kelam @ 2024-04-04 11:24 UTC (permalink / raw)
  To: netdev, linux-kernel
  Cc: pabeni, kuba, edumazet, davem, sbhatta, gakula, sgoutham, naveenm

Inorder to support shaping and scheduling, Upon class creation
Netdev driver allocates trasmit schedulers.

The previous patch which added support for Round robin scheduling has
a bug due to which driver is not freeing transmit schedulers post
class deletion.

This patch fixes the same.

Fixes: 47a9656f168a ("octeontx2-pf: htb offload support for Round Robin scheduling")
Signed-off-by: Hariprasad Kelam <hkelam@marvell.com>
---
 drivers/net/ethernet/marvell/octeontx2/nic/qos.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/qos.c b/drivers/net/ethernet/marvell/octeontx2/nic/qos.c
index 1e77bbf5d22a..1723e9912ae0 100644
--- a/drivers/net/ethernet/marvell/octeontx2/nic/qos.c
+++ b/drivers/net/ethernet/marvell/octeontx2/nic/qos.c
@@ -382,6 +382,7 @@ static void otx2_qos_read_txschq_cfg_tl(struct otx2_qos_node *parent,
 		otx2_qos_read_txschq_cfg_tl(node, cfg);
 		cnt = cfg->static_node_pos[node->level];
 		cfg->schq_contig_list[node->level][cnt] = node->schq;
+		cfg->schq_index_used[node->level][cnt] = true;
 		cfg->schq_contig[node->level]++;
 		cfg->static_node_pos[node->level]++;
 		otx2_qos_read_txschq_cfg_schq(node, cfg);
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [net Patch] octeontx2-pf: Fix transmit scheduler resource leak
  2024-04-04 11:24 [net Patch] octeontx2-pf: Fix transmit scheduler resource leak Hariprasad Kelam
@ 2024-04-07 14:50 ` patchwork-bot+netdevbpf
  0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-04-07 14:50 UTC (permalink / raw)
  To: Hariprasad Kelam
  Cc: netdev, linux-kernel, pabeni, kuba, edumazet, davem, sbhatta,
	gakula, sgoutham, naveenm

Hello:

This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:

On Thu, 4 Apr 2024 16:54:27 +0530 you wrote:
> Inorder to support shaping and scheduling, Upon class creation
> Netdev driver allocates trasmit schedulers.
> 
> The previous patch which added support for Round robin scheduling has
> a bug due to which driver is not freeing transmit schedulers post
> class deletion.
> 
> [...]

Here is the summary with links:
  - [net] octeontx2-pf: Fix transmit scheduler resource leak
    https://git.kernel.org/netdev/net/c/bccb798e07f8

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-04-07 14:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-04 11:24 [net Patch] octeontx2-pf: Fix transmit scheduler resource leak Hariprasad Kelam
2024-04-07 14:50 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).