From: patchwork-bot+netdevbpf@kernel.org
To: Jiri Benc <jbenc@redhat.com>
Cc: netdev@vger.kernel.org, stephen@networkplumber.org,
dsahern@kernel.org, edumazet@google.com
Subject: Re: [PATCH net v2] ipv6: fix race condition between ipv6_get_ifaddr and ipv6_del_addr
Date: Wed, 10 Apr 2024 00:30:30 +0000 [thread overview]
Message-ID: <171270903045.7096.13589832911072928239.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <8ab821e36073a4a406c50ec83c9e8dc586c539e4.1712585809.git.jbenc@redhat.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 8 Apr 2024 16:18:21 +0200 you wrote:
> Although ipv6_get_ifaddr walks inet6_addr_lst under the RCU lock, it
> still means hlist_for_each_entry_rcu can return an item that got removed
> from the list. The memory itself of such item is not freed thanks to RCU
> but nothing guarantees the actual content of the memory is sane.
>
> In particular, the reference count can be zero. This can happen if
> ipv6_del_addr is called in parallel. ipv6_del_addr removes the entry
> from inet6_addr_lst (hlist_del_init_rcu(&ifp->addr_lst)) and drops all
> references (__in6_ifa_put(ifp) + in6_ifa_put(ifp)). With bad enough
> timing, this can happen:
>
> [...]
Here is the summary with links:
- [net,v2] ipv6: fix race condition between ipv6_get_ifaddr and ipv6_del_addr
https://git.kernel.org/netdev/net/c/7633c4da919a
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-04-10 0:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-08 14:18 [PATCH net v2] ipv6: fix race condition between ipv6_get_ifaddr and ipv6_del_addr Jiri Benc
2024-04-10 0:30 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171270903045.7096.13589832911072928239.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=jbenc@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).