* [PATCH] mnl: initialize generic netlink version
@ 2024-04-15 16:33 Stephen Hemminger
2024-04-16 15:40 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Stephen Hemminger @ 2024-04-15 16:33 UTC (permalink / raw)
To: netdev; +Cc: Parav Pandit, Jon Maloy, Jiri Pirko, Stephen Hemminger
The version field in mnlu was being passed in but never set.
This meant that all places mnlu_gen_socket was used, the version would
be uninitialized data from malloc().
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
lib/mnl_utils.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/mnl_utils.c b/lib/mnl_utils.c
index af5aa4f9..6c8f527e 100644
--- a/lib/mnl_utils.c
+++ b/lib/mnl_utils.c
@@ -193,6 +193,8 @@ int mnlu_gen_socket_open(struct mnlu_gen_socket *nlg, const char *family_name,
if (!nlg->nl)
goto err_socket_open;
+ nlg->version = version;
+
err = family_get(nlg, family_name);
if (err)
goto err_socket;
--
2.43.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mnl: initialize generic netlink version
2024-04-15 16:33 [PATCH] mnl: initialize generic netlink version Stephen Hemminger
@ 2024-04-16 15:40 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-04-16 15:40 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: netdev, parav, jmaloy, jiri
Hello:
This patch was applied to iproute2/iproute2.git (main)
by Stephen Hemminger <stephen@networkplumber.org>:
On Mon, 15 Apr 2024 09:33:47 -0700 you wrote:
> The version field in mnlu was being passed in but never set.
> This meant that all places mnlu_gen_socket was used, the version would
> be uninitialized data from malloc().
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> lib/mnl_utils.c | 2 ++
> 1 file changed, 2 insertions(+)
Here is the summary with links:
- mnl: initialize generic netlink version
https://git.kernel.org/pub/scm/network/iproute2/iproute2.git/commit/?id=0a1e1522cde9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-04-16 15:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-15 16:33 [PATCH] mnl: initialize generic netlink version Stephen Hemminger
2024-04-16 15:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).