From: patchwork-bot+netdevbpf@kernel.org
To: Eric Dumazet <edumazet@google.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, dsahern@kernel.org,
eric.dumazet@gmail.com, andreas.a.roeseler@gmail.com
Subject: Re: [PATCH v2 net] icmp: prevent possible NULL dereferences from icmp_build_probe()
Date: Mon, 22 Apr 2024 09:10:26 +0000 [thread overview]
Message-ID: <171377702683.3149.2854361679328570094.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240420070116.4023672-1-edumazet@google.com>
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Sat, 20 Apr 2024 07:01:16 +0000 you wrote:
> First problem is a double call to __in_dev_get_rcu(), because
> the second one could return NULL.
>
> if (__in_dev_get_rcu(dev) && __in_dev_get_rcu(dev)->ifa_list)
>
> Second problem is a read from dev->ip6_ptr with no NULL check:
>
> [...]
Here is the summary with links:
- [v2,net] icmp: prevent possible NULL dereferences from icmp_build_probe()
https://git.kernel.org/netdev/net/c/c58e88d49097
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-04-22 9:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-20 7:01 [PATCH v2 net] icmp: prevent possible NULL dereferences from icmp_build_probe() Eric Dumazet
2024-04-21 1:09 ` David Ahern
2024-04-22 9:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171377702683.3149.2854361679328570094.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andreas.a.roeseler@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).