From: patchwork-bot+netdevbpf@kernel.org
To: =?utf-8?q?Peter_M=C3=BCnster_=3Cpm=40a16n=2Enet=3E?=@ci.codeaurora.org
Cc: netdev@vger.kernel.org, michael.chan@broadcom.com
Subject: Re: [PATCH net v4] net: b44: set pause params only when interface is up
Date: Thu, 25 Apr 2024 15:40:29 +0000 [thread overview]
Message-ID: <171405962996.10966.1317044622368248803.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <87y192oolj.fsf@a16n.net>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 24 Apr 2024 15:51:52 +0200 you wrote:
> b44_free_rings() accesses b44::rx_buffers (and ::tx_buffers)
> unconditionally, but b44::rx_buffers is only valid when the
> device is up (they get allocated in b44_open(), and deallocated
> again in b44_close()), any other time these are just a NULL pointers.
>
> So if you try to change the pause params while the network interface
> is disabled/administratively down, everything explodes (which likely
> netifd tries to do).
>
> [...]
Here is the summary with links:
- [net,v4] net: b44: set pause params only when interface is up
https://git.kernel.org/netdev/net/c/e3eb7dd47bd4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-04-25 15:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-24 13:51 [PATCH net v4] net: b44: set pause params only when interface is up Peter Münster
2024-04-24 16:37 ` Michael Chan
2024-04-25 5:20 ` Hariprasad Kelam
2024-04-25 15:40 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171405962996.10966.1317044622368248803.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc==?utf-8?q?Peter_M=C3=BCnster_=3Cpm=40a16n=2Enet=3E?=@ci.codeaurora.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).