From: patchwork-bot+netdevbpf@kernel.org
To: Eric Dumazet <edumazet@google.com>
Cc: davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
netdev@vger.kernel.org, eric.dumazet@gmail.com,
nhorman@tuxdriver.com, daniel@iogearbox.net,
willemdebruijn.kernel@gmail.com
Subject: Re: [PATCH net] af_packet: do not call packet_read_pending() from tpacket_destruct_skb()
Date: Fri, 17 May 2024 02:40:30 +0000 [thread overview]
Message-ID: <171591363074.2697.13112927096928807724.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240515163358.4105915-1-edumazet@google.com>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Wed, 15 May 2024 16:33:58 +0000 you wrote:
> trafgen performance considerably sank on hosts with many cores
> after the blamed commit.
>
> packet_read_pending() is very expensive, and calling it
> in af_packet fast path defeats Daniel intent in commit
> b013840810c2 ("packet: use percpu mmap tx frame pending refcount")
>
> [...]
Here is the summary with links:
- [net] af_packet: do not call packet_read_pending() from tpacket_destruct_skb()
https://git.kernel.org/netdev/net/c/581073f626e3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
next prev parent reply other threads:[~2024-05-17 2:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-15 16:33 [PATCH net] af_packet: do not call packet_read_pending() from tpacket_destruct_skb() Eric Dumazet
2024-05-15 18:02 ` Willem de Bruijn
2024-05-17 2:40 ` patchwork-bot+netdevbpf [this message]
2024-05-21 9:34 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171591363074.2697.13112927096928807724.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).