From: patchwork-bot+netdevbpf@kernel.org
To: Thadeu Lima de Souza Cascardo <cascardo@igalia.com>
Cc: netdev@vger.kernel.org, cong.wang@bytedance.com,
jakub@cloudflare.com, edumazet@google.com, daniel@iogearbox.net,
john.fastabend@gmail.com, davem@davemloft.net, kuba@kernel.org,
ast@kernel.org, pabeni@redhat.com, bpf@vger.kernel.org,
kernel-dev@igalia.com,
syzbot+07a2e4a1a57118ef7355@syzkaller.appspotmail.com,
stable@vger.kernel.org
Subject: Re: [PATCH net v2] sock_map: avoid race between sock_map_close and sk_psock_put
Date: Tue, 28 May 2024 10:20:29 +0000 [thread overview]
Message-ID: <171689162997.24184.10361719946392416490.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20240524144702.1178377-1-cascardo@igalia.com>
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Fri, 24 May 2024 11:47:02 -0300 you wrote:
> sk_psock_get will return NULL if the refcount of psock has gone to 0, which
> will happen when the last call of sk_psock_put is done. However,
> sk_psock_drop may not have finished yet, so the close callback will still
> point to sock_map_close despite psock being NULL.
>
> This can be reproduced with a thread deleting an element from the sock map,
> while the second one creates a socket, adds it to the map and closes it.
>
> [...]
Here is the summary with links:
- [net,v2] sock_map: avoid race between sock_map_close and sk_psock_put
https://git.kernel.org/netdev/net/c/4b4647add7d3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2024-05-28 10:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-24 14:47 [PATCH net v2] sock_map: avoid race between sock_map_close and sk_psock_put Thadeu Lima de Souza Cascardo
2024-05-27 9:51 ` Jakub Sitnicki
2024-05-28 20:20 ` John Fastabend
2024-05-28 10:20 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=171689162997.24184.10361719946392416490.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=cascardo@igalia.com \
--cc=cong.wang@bytedance.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jakub@cloudflare.com \
--cc=john.fastabend@gmail.com \
--cc=kernel-dev@igalia.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
--cc=syzbot+07a2e4a1a57118ef7355@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).