netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] net: caif: remove unused structs
@ 2024-05-31 23:29 linux
  2024-06-01  0:19 ` Jacob Keller
  2024-06-05  9:20 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: linux @ 2024-05-31 23:29 UTC (permalink / raw)
  To: davem, edumazet, kuba, pabeni
  Cc: netdev, linux-kernel, Dr. David Alan Gilbert

From: "Dr. David Alan Gilbert" <linux@treblig.org>

'cfpktq' has been unused since
commit 73d6ac633c6c ("caif: code cleanup").

'caif_packet_funcs' is declared but never defined.

Remove both of them.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 include/net/caif/caif_layer.h | 2 --
 net/caif/cfpkt_skbuff.c       | 7 -------
 2 files changed, 9 deletions(-)

diff --git a/include/net/caif/caif_layer.h b/include/net/caif/caif_layer.h
index 51f7bb42a936..0f45d875905f 100644
--- a/include/net/caif/caif_layer.h
+++ b/include/net/caif/caif_layer.h
@@ -11,9 +11,7 @@
 
 struct cflayer;
 struct cfpkt;
-struct cfpktq;
 struct caif_payload_info;
-struct caif_packet_funcs;
 
 #define CAIF_LAYER_NAME_SZ 16
 
diff --git a/net/caif/cfpkt_skbuff.c b/net/caif/cfpkt_skbuff.c
index 7796414d47e5..2ae8cfa3df88 100644
--- a/net/caif/cfpkt_skbuff.c
+++ b/net/caif/cfpkt_skbuff.c
@@ -21,13 +21,6 @@ do {					   \
 	pr_warn(errmsg);		   \
 } while (0)
 
-struct cfpktq {
-	struct sk_buff_head head;
-	atomic_t count;
-	/* Lock protects count updates */
-	spinlock_t lock;
-};
-
 /*
  * net/caif/ is generic and does not
  * understand SKB, so we do this typecast
-- 
2.45.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: caif: remove unused structs
  2024-05-31 23:29 [PATCH] net: caif: remove unused structs linux
@ 2024-06-01  0:19 ` Jacob Keller
  2024-06-05  9:20 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Jacob Keller @ 2024-06-01  0:19 UTC (permalink / raw)
  To: linux, davem, edumazet, kuba, pabeni; +Cc: netdev, linux-kernel



On 5/31/2024 4:29 PM, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'cfpktq' has been unused since
> commit 73d6ac633c6c ("caif: code cleanup").
> 
> 'caif_packet_funcs' is declared but never defined.
> 
> Remove both of them.
> 
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] net: caif: remove unused structs
  2024-05-31 23:29 [PATCH] net: caif: remove unused structs linux
  2024-06-01  0:19 ` Jacob Keller
@ 2024-06-05  9:20 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-06-05  9:20 UTC (permalink / raw)
  To: Dr. David Alan Gilbert
  Cc: davem, edumazet, kuba, pabeni, netdev, linux-kernel

Hello:

This patch was applied to netdev/net-next.git (main)
by David S. Miller <davem@davemloft.net>:

On Sat,  1 Jun 2024 00:29:17 +0100 you wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
> 
> 'cfpktq' has been unused since
> commit 73d6ac633c6c ("caif: code cleanup").
> 
> 'caif_packet_funcs' is declared but never defined.
> 
> [...]

Here is the summary with links:
  - net: caif: remove unused structs
    https://git.kernel.org/netdev/net-next/c/6f49c3fb563c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-06-05  9:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-31 23:29 [PATCH] net: caif: remove unused structs linux
2024-06-01  0:19 ` Jacob Keller
2024-06-05  9:20 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).