* [PATCH net] ptp: Fix error message on failed pin verification
@ 2024-06-04 12:05 Karol Kolacinski
2024-06-04 14:59 ` Richard Cochran
2024-06-05 23:10 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Karol Kolacinski @ 2024-06-04 12:05 UTC (permalink / raw)
To: davem, kuba, pabeni; +Cc: netdev, richardcochran, Karol Kolacinski
On failed verification of PTP clock pin, error message prints channel
number instead of pin index after "pin", which is incorrect.
Fix error message by adding channel number to the message and printing
pin number instead of channel number.
Fixes: 6092315dfdec ("ptp: introduce programmable pins.")
Cc: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com>
---
drivers/ptp/ptp_chardev.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/ptp/ptp_chardev.c b/drivers/ptp/ptp_chardev.c
index 7513018c9f9a..2067b0120d08 100644
--- a/drivers/ptp/ptp_chardev.c
+++ b/drivers/ptp/ptp_chardev.c
@@ -85,7 +85,8 @@ int ptp_set_pinfunc(struct ptp_clock *ptp, unsigned int pin,
}
if (info->verify(info, pin, func, chan)) {
- pr_err("driver cannot use function %u on pin %u\n", func, chan);
+ pr_err("driver cannot use function %u and channel %u on pin %u\n",
+ func, chan, pin);
return -EOPNOTSUPP;
}
base-commit: 2ab79514109578fc4b6df90633d500cf281eb689
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] ptp: Fix error message on failed pin verification
2024-06-04 12:05 [PATCH net] ptp: Fix error message on failed pin verification Karol Kolacinski
@ 2024-06-04 14:59 ` Richard Cochran
2024-06-05 23:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Richard Cochran @ 2024-06-04 14:59 UTC (permalink / raw)
To: Karol Kolacinski; +Cc: davem, kuba, pabeni, netdev
On Tue, Jun 04, 2024 at 02:05:27PM +0200, Karol Kolacinski wrote:
> On failed verification of PTP clock pin, error message prints channel
> number instead of pin index after "pin", which is incorrect.
>
> Fix error message by adding channel number to the message and printing
> pin number instead of channel number.
>
> Fixes: 6092315dfdec ("ptp: introduce programmable pins.")
> Cc: Richard Cochran <richardcochran@gmail.com>
> Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com>
Nice find!
Acked-by: Richard Cochran <richardcochran@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] ptp: Fix error message on failed pin verification
2024-06-04 12:05 [PATCH net] ptp: Fix error message on failed pin verification Karol Kolacinski
2024-06-04 14:59 ` Richard Cochran
@ 2024-06-05 23:10 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2024-06-05 23:10 UTC (permalink / raw)
To: Karol Kolacinski; +Cc: davem, kuba, pabeni, netdev, richardcochran
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Tue, 4 Jun 2024 14:05:27 +0200 you wrote:
> On failed verification of PTP clock pin, error message prints channel
> number instead of pin index after "pin", which is incorrect.
>
> Fix error message by adding channel number to the message and printing
> pin number instead of channel number.
>
> Fixes: 6092315dfdec ("ptp: introduce programmable pins.")
> Cc: Richard Cochran <richardcochran@gmail.com>
> Signed-off-by: Karol Kolacinski <karol.kolacinski@intel.com>
>
> [...]
Here is the summary with links:
- [net] ptp: Fix error message on failed pin verification
https://git.kernel.org/netdev/net/c/323a359f9b07
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-06-05 23:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-04 12:05 [PATCH net] ptp: Fix error message on failed pin verification Karol Kolacinski
2024-06-04 14:59 ` Richard Cochran
2024-06-05 23:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).